From 282f830c3374147d603eb90925029d2c94335cd4 Mon Sep 17 00:00:00 2001 From: Matt Butrovich Date: Fri, 7 Nov 2025 14:44:15 -0500 Subject: [PATCH 1/2] Fix float normalize_nan bug? --- native/spark-expr/src/math_funcs/internal/normalize_nan.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/native/spark-expr/src/math_funcs/internal/normalize_nan.rs b/native/spark-expr/src/math_funcs/internal/normalize_nan.rs index 7f564aa0df..a12be0e94d 100644 --- a/native/spark-expr/src/math_funcs/internal/normalize_nan.rs +++ b/native/spark-expr/src/math_funcs/internal/normalize_nan.rs @@ -15,6 +15,8 @@ // specific language governing permissions and limitations // under the License. +use arrow::array::Array; +use arrow::compute::cast; use arrow::datatypes::{DataType, Schema}; use arrow::{ array::{as_primitive_array, ArrayAccessor, ArrayIter, Float32Array, Float64Array}, @@ -92,7 +94,7 @@ impl PhysicalExpr for NormalizeNaNAndZero { } fn children(&self) -> Vec<&Arc> { - self.child.children() + vec![&self.child] } fn with_new_children( From 3421af248d2e03bed9c20bfe114d31a0aeb9a3f0 Mon Sep 17 00:00:00 2001 From: Matt Butrovich Date: Fri, 7 Nov 2025 14:49:25 -0500 Subject: [PATCH 2/2] Remove unused imports. --- native/spark-expr/src/math_funcs/internal/normalize_nan.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/native/spark-expr/src/math_funcs/internal/normalize_nan.rs b/native/spark-expr/src/math_funcs/internal/normalize_nan.rs index a12be0e94d..0bd556ed73 100644 --- a/native/spark-expr/src/math_funcs/internal/normalize_nan.rs +++ b/native/spark-expr/src/math_funcs/internal/normalize_nan.rs @@ -15,8 +15,6 @@ // specific language governing permissions and limitations // under the License. -use arrow::array::Array; -use arrow::compute::cast; use arrow::datatypes::{DataType, Schema}; use arrow::{ array::{as_primitive_array, ArrayAccessor, ArrayIter, Float32Array, Float64Array},