Cache non-exist timeseries metadata to reduce IO#16606
Open
Cache non-exist timeseries metadata to reduce IO#16606
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16606 +/- ##
============================================
+ Coverage 39.47% 39.48% +0.01%
Complexity 282 282
============================================
Files 5098 5098
Lines 341273 341321 +48
Branches 43471 43474 +3
============================================
+ Hits 134714 134772 +58
+ Misses 206559 206549 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/DataNodeMemoryConfig.java
…he/iotdb into cache_non_exist_timeseries_metadata # Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/DataNodeMemoryConfig.java
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When repeatedly querying a timeseries that is not in a TsFile and the bloomfilter fails to filter it, each query will result in a necessary IO.
Since TsFile is immutable, we can cache a placeholder to indicate the non-existence.
In a test, 10000 series were written into a TsFile, then 20000 series (only 10000 exist) were queried from the file.
The result shows a significant reduction in query time.
For 0.25M timeseries
For 1M timeseries