You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a boot smoke test for ComputingUnitMaster to the amber-integration job, mirroring the texera-web boot test added in #6319 (and the platform-service boot tests in #6274). Suggested by @Yicong-Huang in the #6319 review.
ComputingUnitMaster is the other server built from the amber dist (bin/computing-unit-master, port 8085); like texera-web it compiles and unit-tests clean but a runtime classpath/linkage regression (the #6204 class of bug) would only surface when its packaged launcher is actually started — which nothing in CI does today.
It boots on postgres only, which amber-integration already provisions — verified against ComputingUnitMaster.main/run:
clusterMode defaults to false (no --cluster arg), so AmberRuntime.startActorMaster(false) binds a local Pekko actor system on localhost:2552 and self-seeds a single-node cluster — no external infra, and the external getNodeIpAddress call (checkip.amazonaws.com) is only reached in cluster mode.
ApplicationConfig.cleanupAllExecutionResults defaults to false (asserted in ApplicationConfigSpec), so the boot-time result-storage cleanup (which would touch the iceberg/S3 result store) is skipped.
The recurring expired-result check is scheduled 2s post-boot but finds no executions in the fresh (empty) texera_db, so it does no result-storage work.
Config resolves the same way as texera-web — Utils.amberHomePath (a working-dir search for amber) → amber/src/main/resources/computing-unit-master-config.yml.
Task Summary
Add a boot smoke test for
ComputingUnitMasterto theamber-integrationjob, mirroring thetexera-webboot test added in #6319 (and the platform-service boot tests in #6274). Suggested by @Yicong-Huang in the #6319 review.ComputingUnitMasteris the other server built from the amber dist (bin/computing-unit-master, port 8085); liketexera-webit compiles and unit-tests clean but a runtime classpath/linkage regression (the #6204 class of bug) would only surface when its packaged launcher is actually started — which nothing in CI does today.Current state
bin/texera-web-application(port 8080) inamber-integrationvia.github/scripts/smoke-boot.sh, building the amber dist in-job (ubuntu-only, no artifact hand-off).bin/computing-unit-masteris produced by the sameWorkflowExecutionService/distbut is not booted anywhere in CI.Suggested direction
Add one more boot step in
amber-integration, reusing the amber dist that #6319 already builds and unzips:It boots on postgres only, which
amber-integrationalready provisions — verified againstComputingUnitMaster.main/run:clusterModedefaults tofalse(no--clusterarg), soAmberRuntime.startActorMaster(false)binds a local Pekko actor system onlocalhost:2552and self-seeds a single-node cluster — no external infra, and the externalgetNodeIpAddresscall (checkip.amazonaws.com) is only reached in cluster mode.ApplicationConfig.cleanupAllExecutionResultsdefaults tofalse(asserted inApplicationConfigSpec), so the boot-time result-storage cleanup (which would touch the iceberg/S3 result store) is skipped.texera_db, so it does no result-storage work.texera-web—Utils.amberHomePath(a working-dir search foramber) →amber/src/main/resources/computing-unit-master-config.yml.Task Type