Skip to content

Follow-up: a7 test / skills / docs review findings #1

@guoqqqi

Description

@guoqqqi

Background

Before putting a7 into actual use, I completed a full review and local rerun of the current test suite, skills, and documentation.

Current Conclusions

  • The CI baseline tests are passing.
  • A local rerun can pass if it strictly follows the current CI E2E workflow.
  • However, that “pass” still includes a large number of skips.
  • After adding A7_GATEWAY_URL=http://192.168.10.100:19080 and HTTPBIN_URL=http://192.168.10.100:3030, many previously skipped traffic-related cases exposed real issues.
  • The current skills setup has no dedicated E2E coverage and no validate-skills.
  • The current overall code coverage is about 41.4%.

Main Issues

1. The test models for route / debug / stream-route / secret do not match the current EE API

Confirmed issues include:

  • The route create tests still build requests based on the old model and are missing the service_id now required by EE.
  • The debug trace tests still use the old route model, which causes real failures.
  • The stream-route tests are inconsistent with the current schema requirements.
  • The secret documentation and tests use parameter formats that do not match the current CLI.

2. Missing automation for skills

  • No scripts/validate-skills.sh
  • No make validate-skills
  • No test/e2e/skills

3. The skills documentation is inconsistent with the current implementation and environment

Confirmed issues include:

  • docs/skills.md declares skill names that do not actually exist in the repository.
  • The persona documentation references commands that do not exist in the current CLI, such as health and portal.
  • Several recipe documents are still written around the old route/upstream model.
  • upstream create returns resource not found directly in the current EE environment.

Items That Still Need Follow-up

P0

  • Rewrite the route-related E2E tests

    • Use the currently valid model: service create + route create(service_id)
  • Rewrite the debug trace E2E tests

    • Base them on the current working route/service model
  • Rewrite the stream-route E2E tests

    • Align them with the current schema
  • Rewrite the secret E2E tests

    • Align them with the current CLI parameter format
  • Rewrite auth-related scenario validation

    • Standardize on the currently supported credential create model
  • Add automation for skills

    • validate-skills
    • test/e2e/skills

P1

  • Systematically fix outdated model examples in the documentation

    • route
    • upstream
    • debug
    • auth
    • recipe
  • Fix the nonexistent skill names and roadmap items in docs/skills.md

  • Perform a cleanup pass on existing skills for actual usability in the current environment

    • Distinguish between: usable, docs need updates, depends on external systems, currently unavailable

P2

  • Continue adding unit tests and gradually improve coverage
  • Turn key behaviors that are currently only manually verifiable into automated tests

Suggested Deliverables

  • First, complete a round of model correction

    • Unify the tests and documentation for route / credential / debug / stream-route / secret with the current EE API
  • Then, add automation for skills

    • Do not pile automation on top of an outdated model
  • Final outcome:

    • maintainable E2E tests
    • executable skill validation
    • documentation that matches the current implementation

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions