Skip to content

Commit 16a004a

Browse files
committed
feat: arm builds bb
1 parent 9cdc082 commit 16a004a

20 files changed

Lines changed: 198 additions & 31 deletions

File tree

.github/workflows/release-node-playwright.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ jobs:
235235
build-args: |
236236
NODE_VERSION=${{ matrix.node-version }}
237237
PLAYWRIGHT_VERSION=${{ format('v{0}-', matrix.playwright-version) }}
238-
platforms: linux/amd64
238+
platforms: linux/amd64${{ (matrix.image-name != 'node-playwright' && matrix.image-name != 'node-playwright-chrome' && ',linux/arm64') || '' }}
239239
provenance: true
240240
push: true
241241
tags: ${{ fromJson(steps.prepare-tags.outputs.result).allTags }}

.github/workflows/release-node.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ jobs:
221221
context: ./${{ matrix.image-name }}
222222
file: ./${{ matrix.image-name }}/Dockerfile
223223
build-args: NODE_VERSION=${{ matrix.node-version }}
224-
platforms: linux/amd64
224+
platforms: linux/amd64,linux/arm64
225225
provenance: true
226226
push: true
227227
tags: ${{ fromJson(steps.prepare-tags.outputs.result).allTags }}

.github/workflows/release-python-playwright.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,8 @@ jobs:
218218
PYTHON_VERSION=${{ matrix.python-version }}
219219
APIFY_VERSION=${{ env.APIFY_VERSION }}
220220
PLAYWRIGHT_VERSION=${{ matrix.playwright-version }}
221-
platforms: linux/amd64
221+
# TODO: linux/arm64 will only work if we do NOT install google-chrome like we did in node-playwright(-chrome)
222+
platforms: linux/amd64,linux/arm64
222223
provenance: true
223224
push: true
224225
tags: ${{ fromJson(steps.prepare-tags.outputs.result).allTags }}

.github/workflows/release-python.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ jobs:
214214
build-args: |
215215
PYTHON_VERSION=${{ matrix.python-version }}
216216
APIFY_VERSION=${{ env.APIFY_VERSION }}
217-
platforms: linux/amd64
217+
platforms: linux/amd64,linux/arm64
218218
provenance: true
219219
push: true
220220
tags: ${{ fromJson(steps.prepare-tags.outputs.result).allTags }}

Makefile

Lines changed: 166 additions & 16 deletions
Large diffs are not rendered by default.

node-playwright-camoufox/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
ARG NODE_VERSION=20
1+
ARG NODE_VERSION=22
22
# Use trixie to be consistent across node versions.
3-
FROM --platform=linux/amd64 node:${NODE_VERSION}-trixie-slim
3+
FROM node:${NODE_VERSION}-trixie-slim
44

55
LABEL maintainer="support@apify.com" description="Base image for Apify Actors using Camoufox"
66
ENV DEBIAN_FRONTEND=noninteractive
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#!/bin/bash
22

3+
echo "Running on architecture: $(uname -m)"
4+
35
echo "Will run command: xvfb-run -a -s \"-ac -screen 0 $XVFB_WHD -nolisten tcp\" $@"
46
xvfb-run -a -s "-ac -screen 0 $XVFB_WHD -nolisten tcp" "$@"

node-playwright-chrome/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
ARG NODE_VERSION=20
1+
ARG NODE_VERSION=22
22
# Use trixie to be consistent across node versions.
33
FROM --platform=linux/amd64 node:${NODE_VERSION}-trixie-slim
44

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#!/bin/bash
22

3+
echo "Running on architecture: $(uname -m)"
4+
35
echo "Will run command: xvfb-run -a -s \"-ac -screen 0 $XVFB_WHD -nolisten tcp\" $@"
46
xvfb-run -a -s "-ac -screen 0 $XVFB_WHD -nolisten tcp" "$@"

node-playwright-firefox/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
ARG NODE_VERSION=20
1+
ARG NODE_VERSION=22
22
# Use trixie to be consistent across node versions.
3-
FROM --platform=linux/amd64 node:${NODE_VERSION}-trixie-slim
3+
FROM node:${NODE_VERSION}-trixie-slim
44

55
LABEL maintainer="support@apify.com" description="Base image for Apify Actors using Firefox"
66
ENV DEBIAN_FRONTEND=noninteractive

0 commit comments

Comments
 (0)