fix: enhance PR title generation with retries and better errors

- Add retry logic for generating the pull request title, retrying up to 3 times if the response is empty
- Return an explicit error if the OpenAI API returns no choices, or if reasoning content is present (unsupported)
- Improve error reporting for failed title generation attempts

fix #242

Signed-off-by: appleboy <[email protected]>

Author: appleboy

cmd/commit.go

@@ -1,6 +1,7 @@
 package cmd
 
 import (
+	"fmt"
 	"html"
 	"os"
 	"path"
@@ -163,14 +164,36 @@ var commitCmd = &cobra.Command{
 				return err
 			}
 
-			// Generate title for pull request
+			// Generate title for pull request with retry if empty
 			color.Cyan("Generating title for pull request...")
-			resp, err := client.Completion(cmd.Context(), out)
-			if err != nil {
-				return err
+			const maxRetries = 3
+			const retryDelay = 500 * time.Millisecond
+
+			var summarizeTitle string
+			var resp *core.Response
+
+			for attempt := 1; attempt <= maxRetries; attempt++ {
+				resp, err = client.Completion(cmd.Context(), out)
+				if err != nil {
+					return err
+				}
+
+				summarizeTitle = strings.TrimSpace(resp.Content)
+				color.Magenta(resp.Usage.String())
+
+				if len(summarizeTitle) > 0 {
+					break
+				}
+
+				if attempt < maxRetries {
+					color.Cyan("Empty title response, retrying (%d/%d)...", attempt, maxRetries)
+					time.Sleep(retryDelay)
+				}
+			}
+
+			if len(summarizeTitle) == 0 {
+				return fmt.Errorf("failed to get valid title after %d attempts", maxRetries)
 			}
-			summarizeTitle := resp.Content
-			color.Magenta(resp.Usage.String())
 
 			// Lowercase the first character of first word of the commit message and remove the trailing period
 			summarizeTitle = strings.TrimRight(strings.ToLower(string(summarizeTitle[0]))+summarizeTitle[1:], ".")

provider/openai/openai.go

@@ -180,6 +180,13 @@ func (c *Client) completion(
 	if err != nil {
 		return nil, err
 	}
+	if len(r.Choices) == 0 {
+		return nil, fmt.Errorf("no choices returned from API")
+	}
+	// Do not support reasoning content for now.
+	if r.Choices[0].Message.ReasoningContent != "" {
+		return nil, fmt.Errorf("reasoning model is not supported")
+	}
 	resp.Content = r.Choices[0].Message.Content
 	resp.Usage = r.Usage
 	return resp, nil