Skip to content

Commit 1bd44bb

Browse files
authored
docs(example): Fix broken links in docs. Fixes #4382 (#4403)
Fix broken links in docs Signed-off-by: Kevin Park <[email protected]>
1 parent 81d412d commit 1bd44bb

File tree

10 files changed

+18
-12
lines changed

10 files changed

+18
-12
lines changed

docs/features/canary/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ There are multiple steps available, the most basic ones are `setWeight` and `pau
1010

1111
!!! important
1212

13-
If the canary Rollout does not use [traffic management](traffic-management/index.md), the Rollout makes a best effort attempt to achieve the percentage listed in the last `setWeight` step between the new and old version. For example, if a Rollout has 10 Replicas and 10% for the first `setWeight` step, the controller will scale the new desired ReplicaSet to 1 replicas and the old stable ReplicaSet to 9. In the case where the setWeight is 41%, the Rollout attempts to get there by finding the whole number with the smallest delta, rounding up the calculation if the deltas are equals (i.e. the new ReplicaSet has 4 pods since 41% of 10 is closer to 4/10 than 5/10, and the old ReplicaSet has 6 pods). If a user wants to have more fine-grained control of the percentages without a large number of Replicas, that user should use the [traffic management](#trafficrouting) functionality.
13+
If the canary Rollout does not use [traffic management](../traffic-management/index.md), the Rollout makes a best effort attempt to achieve the percentage listed in the last `setWeight` step between the new and old version. For example, if a Rollout has 10 Replicas and 10% for the first `setWeight` step, the controller will scale the new desired ReplicaSet to 1 replicas and the old stable ReplicaSet to 9. In the case where the setWeight is 41%, the Rollout attempts to get there by finding the whole number with the smallest delta, rounding up the calculation if the deltas are equals (i.e. the new ReplicaSet has 4 pods since 41% of 10 is closer to 4/10 than 5/10, and the old ReplicaSet has 6 pods). If a user wants to have more fine-grained control of the percentages without a large number of Replicas, that user should use the [traffic management](#trafficrouting) functionality.
1414

1515
## Example
1616

@@ -64,7 +64,7 @@ spec:
6464
- pause: {} # pause indefinitely
6565
```
6666
67-
If no `duration` is specified for a pause step, the rollout will be paused indefinitely. To unpause, use the [argo kubectl plugin](kubectl-plugin.md) `promote` command.
67+
If no `duration` is specified for a pause step, the rollout will be paused indefinitely. To unpause, use the [argo kubectl plugin](../kubectl-plugin.md) `promote` command.
6868

6969
```shell
7070
# promote to the next step

docs/generated/notification-services/email.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ data:
4646
4747
## Template
4848
49-
[Notification templates](../templates.md) support specifying subject for email notifications:
49+
[Notification templates](../../features/notifications.md#templates) support specifying subject for email notifications:
5050
5151
```yaml
5252
apiVersion: v1

docs/generated/notification-services/pagerduty.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ data:
3535
3636
## Template
3737
38-
[Notification templates](../templates.md) support specifying subject for PagerDuty notifications:
38+
[Notification templates](../../features/notifications.md#templates) support specifying subject for PagerDuty notifications:
3939
4040
```yaml
4141
apiVersion: v1

docs/generated/notification-services/pagerduty_v2.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ data:
3737
3838
## Template
3939
40-
[Notification templates](../templates.md) support specifying subject for PagerDuty notifications:
40+
[Notification templates](../../features/notifications.md#templates) support specifying subject for PagerDuty notifications:
4141
4242
```yaml
4343
apiVersion: v1

docs/generated/notification-services/rocketchat.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ metadata:
6464

6565
## Templates
6666

67-
[Notification templates](../templates.md) can be customized with RocketChat [attachments](https://developer.rocket.chat/api/rest-api/methods/chat/postmessage#attachments-detail).
67+
[Notification templates](../../features/notifications.md#templates) can be customized with RocketChat [attachments](https://developer.rocket.chat/api/rest-api/methods/chat/postmessage#attachments-detail).
6868

6969
*Note: Attachments structure in Rocketchat is same with Slack attachments [feature](https://api.slack.com/messaging/composing/layouts).*
7070

docs/generated/notification-services/slack.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ The Slack notification service configuration includes following settings:
5555
token: $slack-token
5656
```
5757

58-
1. Add annotation in application yaml file to enable notifications for specific argocd app. The following example uses the [on-sync-succeeded trigger](../catalog.md#triggers):
58+
1. Add annotation in application yaml file to enable notifications for specific argocd app. The following example uses the [on-sync-succeeded trigger](../../features/notifications.md#custom-triggers):
5959

6060
```yaml
6161
apiVersion: argoproj.io/v1alpha1
@@ -65,7 +65,7 @@ The Slack notification service configuration includes following settings:
6565
notifications.argoproj.io/subscribe.on-sync-succeeded.slack: my_channel
6666
```
6767

68-
1. Annotation with more than one [trigger](../catalog.md#triggers), with multiple destinations and recipients
68+
1. Annotation with more than one [trigger](../../features/notifications.md#custom-triggers), with multiple destinations and recipients
6969

7070
```yaml
7171
apiVersion: argoproj.io/v1alpha1
@@ -87,7 +87,7 @@ The Slack notification service configuration includes following settings:
8787

8888
## Templates
8989

90-
[Notification templates](../templates.md) can be customized to leverage slack message blocks and attachments
90+
[Notification templates](../../features/notifications.md#templates) can be customized to leverage slack message blocks and attachments
9191
[feature](https://api.slack.com/messaging/composing/layouts).
9292

9393
![](https://user-images.githubusercontent.com/426437/72776856-6dcef880-3bc8-11ea-8e3b-c72df16ee8e6.png)

docs/generated/notification-services/teams.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ metadata:
4848
4949
![](https://user-images.githubusercontent.com/18019529/114271500-9d2b8880-9a4c-11eb-85c1-f6935f0431d5.png)
5050
51-
[Notification templates](../templates.md) can be customized to leverage teams message sections, facts, themeColor, summary and potentialAction [feature](https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/connectors-using).
51+
[Notification templates](../../features/notifications.md#templates) can be customized to leverage teams message sections, facts, themeColor, summary and potentialAction [feature](https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/connectors-using).
5252
5353
```yaml
5454
template.app-sync-succeeded: |

docs/getting-started/mixed/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ This guide covers how Argo Rollouts integrates with multiple TrafficRoutings, us
99
should be able to produce any other combination between the existing trafficRouting options.
1010

1111
This guide builds upon the concepts of the [basic getting started guide](../../getting-started.md),
12-
[NGINX Guide](getting-started/nginx/index.md), and [SMI Guide](getting-started/smi/index.md).
12+
[NGINX Guide](../nginx/index.md), and [SMI Guide](../smi/index.md).
1313

1414
## Requirements
1515
- Kubernetes cluster with Linkerd installed

docs/migrating.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ When converting a Deployment to a Rollout, it involves changing three fields:
1111

1212
1. Replacing the `apiVersion` from `apps/v1` to `argoproj.io/v1alpha1`
1313
1. Replacing the `kind` from `Deployment` to `Rollout`
14-
1. Replacing the deployment strategy with a [blue-green](features/bluegreen.md) or [canary](features/canary.md) strategy
14+
2. Replacing the deployment strategy with a [blue-green](features/bluegreen.md) or [canary](features/canary/index.md) strategy
1515

1616
Below is an example of a Rollout resource using the canary strategy.
1717

hack/gen-docs/main.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,12 @@ func generateNotificationsDocs() {
4242
if e := strReplaceDocFiles("argocd-notifications-secret", "argo-rollouts-notification-secret", files); e != nil {
4343
log.Fatal(e)
4444
}
45+
if e := strReplaceDocFiles("../templates.md", "../../features/notifications.md#templates", files); e != nil {
46+
log.Fatal(e)
47+
}
48+
if e := strReplaceDocFiles("../catalog.md#triggers", "../../features/notifications.md#custom-triggers", files); e != nil {
49+
log.Fatal(e)
50+
}
4551
}
4652
}
4753

0 commit comments

Comments
 (0)