Use jira client token for media #1335
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
om-ukr
force-pushed
the
try-jira-tokent
branch
from
9620015 to
347aecb
Compare
![atlassian[bot]](https://avatars.githubusercontent.com/in/14320?s=60&v=4){kind=small}
| viewMediaClientConfig: { | ||
| authProvider: () => | ||
| Promise.resolve({ | ||
| token: '', |
Contributor
There was a problem hiding this comment.
🔥 Code Bugs
The hardcoded empty token and clientId in the media auth provider will prevent media functionality from working properly.
Collaborator
Author
There was a problem hiding this comment.
Yeap, this should be replaced by real call to Jira API to get a token.
| ), | ||
| resolve(JSON.stringify(document)); | ||
| }, | ||
| // { |
Contributor
There was a problem hiding this comment.
🔎 Code Readability
The commented-out transformer code should be removed rather than left as dead code.
| } | ||
|
|
||
| // TODO: Temporary set api version to 3 to get ADF value instead of string(WikiMarkup). At the time we have access to token endpoint v3 should be default for cloud. | ||
| (newClient as any).apiVersion = '3'; |
Contributor
There was a problem hiding this comment.
⚠️ Maintainability - Best Practices
The type cast (newClient as any).apiVersion = '3' bypasses TypeScript safety and could break if the client structure changes.
| setCommentText(''); | ||
| closeEditorHandler(); | ||
| } | ||
| // if (content && content.trim() !== '') { |
Contributor
There was a problem hiding this comment.
🔎 Code Readability
The commented validation logic should be removed entirely rather than left as commented code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: