Avoid tainting too many nodes if their deletion breaches ASG min #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is possible that escalator hits terminating nodes will breach minimum node size condition which prevents it from scaling down/deleting nodes in the nodegroup. This results in empty nodes running for no reason until
ASG_DESIRED - NODES_TO_TERMINATE >= ASG_MIN(ie some manual intervention may be required)Proposed Solution
While this situation can be caused mostly by bad timing and specific escalator configuration (increasing the time until a node would get deleted), it would be good to do some maths before tainting nodes, namely checking if
ASG_DESIRED - NODES_TO_DELTE < ASG_MINin other words run the same check as in DeleteNodes function but before nodes are tainted/marked for removal.