update types to be more generic

Author: osama-rizk

packages/storage/src/providers/s3/apis/internal/removeObjects.ts

@@ -48,29 +48,37 @@ export const removeObjects = async (
 	// Calculate Content-MD5 (required for DeleteObjects)
 	const contentMd5 = await calculateContentMd5(xmlBody);
 
-	const result = await deleteObjects(
-		{
-			...s3Config,
-			userAgentValue: getStorageUserAgentValue(StorageAction.Remove),
+	const deleteObjectsInput = {
+		Bucket: bucket,
+		Delete: {
+			Objects: input.paths.map(path => ({ Key: path })),
+			Quiet: false,
 		},
-		{
-			Bucket: bucket,
-			Delete: {
-				Objects: input.paths.map(path => ({ Key: path })),
-				Quiet: false,
+		ExpectedBucketOwner: input.options?.expectedBucketOwner,
+		ContentMD5: contentMd5,
+	};
+
+	try {
+		const result = await deleteObjects(
+			{
+				...s3Config,
+				userAgentValue: getStorageUserAgentValue(StorageAction.Remove),
 			},
-			ExpectedBucketOwner: input.options?.expectedBucketOwner,
-			ContentMD5: contentMd5,
-		},
-	);
+			deleteObjectsInput,
+		);
 
-	return {
-		deleted: result.Deleted?.map(item => ({ path: item.Key! })) || [],
-		errors:
-			result.Errors?.map(error => ({
-				path: error.Key!,
-				code: error.Code!,
-				message: error.Message!,
-			})) || [],
-	};
+		const output = {
+			deleted: result.Deleted?.map(item => ({ path: item.Key! })) || [],
+			errors:
+				result.Errors?.map(error => ({
+					path: error.Key!,
+					code: error.Code!,
+					message: error.Message!,
+				})) || [],
+		};
+
+		return output;
+	} catch (error) {
+		throw error;
+	}
 };

packages/storage/src/providers/s3/utils/client/s3data/deleteObjects.ts

@@ -52,7 +52,7 @@ const deleteObjectsSerializer = (
 
 	const body = `<?xml version="1.0" encoding="UTF-8"?>
 <Delete xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
-	<Quiet>${input.Delete!.Quiet || false}</Quiet>
+	<Quiet>${input.Delete!.Quiet === true ? 'true' : 'false'}</Quiet>
 	${objects}
 </Delete>`;
 
@@ -62,22 +62,26 @@ const deleteObjectsSerializer = (
 		'content-md5': input.ContentMD5,
 	});
 
-	return {
+	const request = {
 		method: 'POST',
 		headers,
 		url,
 		body,
 	};
+
+	return request;
 };
 
 const deleteObjectsDeserializer = async (
 	response: HttpResponse,
 ): Promise<DeleteObjectsOutput> => {
 	if (response.statusCode >= 300) {
-		throw buildStorageServiceError((await parseXmlError(response))!);
+		const error = await parseXmlError(response);
+		throw buildStorageServiceError(error!);
 	}
 
 	const text = await response.body.text();
+
 	const deleted: { Key?: string }[] = [];
 	const errors: { Key?: string; Code?: string; Message?: string }[] = [];
 
@@ -104,11 +108,13 @@ const deleteObjectsDeserializer = async (
 		});
 	}
 
-	return {
+	const result = {
 		Deleted: deleted,
 		Errors: errors,
 		$metadata: parseMetadata(response),
 	};
+
+	return result;
 };
 
 export const deleteObjects = composeServiceApi(