ci: redo log checking

Author: pranavosu

.github/workflows/reusable-build-system-test-react-native.yml

@@ -155,14 +155,15 @@ jobs:
 
       - name: Cache Android SDK and emulator
         if: ${{ matrix.platform == 'android' }}
+        id: android-cache
         uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
         with:
           path: |
             ~/Library/Android/sdk/system-images
             ~/Library/Android/sdk/build-tools
             ~/Library/Android/sdk/platform-tools
             ~/.android/avd
-          key: ${{ runner.os }}-android-sdk-27-x86_64-v1
+          key: ${{ runner.os }}-android-sdk-27-x86_64-snapshot-v1
         env:
           SEGMENT_DOWNLOAD_TIMEOUT_MINS: 5
 
@@ -204,8 +205,8 @@ jobs:
           $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager --install "build-tools;33.0.2" "platform-tools" "system-images;android-27;default;x86_64"
           $ANDROID_HOME/cmdline-tools/latest/bin/avdmanager create avd --name Pixel_5_API_27 --force --device "pixel_5" --abi x86_64 --package "system-images;android-27;default;x86_64"
 
-      - name: Start Android emulator
-        if: ${{ matrix.platform == 'android' }}
+      - name: Start Android emulator (cold boot - first run)
+        if: ${{ matrix.platform == 'android' && steps.android-cache.outputs.cache-hit != 'true' }}
         run: |
           $ANDROID_HOME/emulator/emulator -avd Pixel_5_API_27 -port ${{ env.EMULATOR_PORT }} -no-boot-anim -no-audio -no-snapshot-load -gpu host -accel on &
           $ANDROID_HOME/platform-tools/adb wait-for-device shell 'while [[ -z $(getprop sys.boot_completed | tr -d '\r') ]]; do sleep 1; done; input keyevent 82'
@@ -216,6 +217,15 @@ jobs:
           $ANDROID_HOME/platform-tools/adb shell settings put global window_animation_scale 0.0
           $ANDROID_HOME/platform-tools/adb shell settings put global transition_animation_scale 0.0
           $ANDROID_HOME/platform-tools/adb shell settings put global animator_duration_scale 0.0
+          # Save snapshot for future runs
+          $ANDROID_HOME/platform-tools/adb emu avd snapshot save default_boot
+
+      - name: Start Android emulator (from snapshot - cached)
+        if: ${{ matrix.platform == 'android' && steps.android-cache.outputs.cache-hit == 'true' }}
+        run: |
+          $ANDROID_HOME/emulator/emulator -avd Pixel_5_API_27 -port ${{ env.EMULATOR_PORT }} -no-boot-anim -no-audio -snapshot default_boot -gpu host -accel on &
+          $ANDROID_HOME/platform-tools/adb wait-for-device shell 'while [[ -z $(getprop sys.boot_completed | tr -d '\r') ]]; do sleep 1; done; input keyevent 82'
+          $ANDROID_HOME/platform-tools/adb devices
 
       - name: Create MegaApp ${{ env.MEGA_APP_NAME }} and run build on NodeJS ${{ matrix.node-version }}
         run: npm run setup:${{matrix.framework}}:${{matrix.build-tool}} -- --name ${{ env.MEGA_APP_NAME }} --platform ${{matrix.platform}} --tag ${{inputs.dist-tag}} --framework-version ${{matrix.framework-version.value}} --build-tool-version ${{matrix.build-tool-version}}

build-system-tests/scripts/checkReactNativeLog.ts

@@ -133,17 +133,77 @@ const checkErrorMessage = async (logLines: string[]): Promise<boolean> => {
   return results.some((result) => result === true);
 };
 
+/**
+ * waitForLogs polls the log file until meaningful content appears or timeout is reached
+ * @returns {string} the log file content
+ */
+const waitForLogs = async (): Promise<string> => {
+  const pollInterval = 10; // seconds between checks
+  const maxWaitTime = 180; // max 3 minutes total wait
+  const minLogLines = 5; // minimum lines to consider logs "ready"
+
+  const startMessages = [
+    'info Starting logkitty',
+    'React Native iOS Logger started for XCode project',
+  ];
+
+  let elapsed = 0;
+  log(
+    'info',
+    `Waiting for logs (polling every ${pollInterval}s, max ${maxWaitTime}s)...`
+  );
+
+  while (elapsed < maxWaitTime) {
+    await sleep(pollInterval);
+    elapsed += pollInterval;
+
+    if (!fs.existsSync(logFileName)) {
+      log('info', `[${elapsed}s] Log file not found yet...`);
+      continue;
+    }
+
+    const logFile = fs.readFileSync(logFileName, 'utf-8');
+    const logLines = logFile.split('\n').filter((line) => line !== '');
+
+    // Check if we only have the start message (logs not ready yet)
+    if (logLines.length === 1) {
+      const isOnlyStartMessage = startMessages.some((msg) =>
+        logLines[0].includes(msg)
+      );
+      if (isOnlyStartMessage) {
+        log('info', `[${elapsed}s] Only start message found, waiting...`);
+        continue;
+      }
+    }
+
+    // Check if we have enough log lines
+    if (logLines.length >= minLogLines) {
+      log(
+        'success',
+        `[${elapsed}s] Found ${logLines.length} log lines, proceeding with check`
+      );
+      return logFile;
+    }
+
+    log(
+      'info',
+      `[${elapsed}s] Found ${logLines.length} lines, waiting for more...`
+    );
+  }
+
+  // Timeout reached, return whatever we have
+  log('warning', `Timeout reached after ${maxWaitTime}s`);
+  if (fs.existsSync(logFileName)) {
+    return fs.readFileSync(logFileName, 'utf-8');
+  }
+  return '';
+};
+
 const checkReactNativeLog = async (): Promise<void> => {
   log('command', `cd mega-apps/${megaAppName}`);
   process.chdir(`mega-apps/${megaAppName}`);
 
-  // Wait for the logging messages to be ready. The number is based on real experiments in Github Actions.
-  const timeToWait = 500;
-
-  log('info', `Sleep for '${timeToWait}' seconds...`);
-  await sleep(timeToWait);
-
-  const logFile = fs.readFileSync(logFileName, 'utf-8');
+  const logFile = await waitForLogs();
   const logLines = logFile.split('\n').filter((line) => line !== '');
 
   await checkStartMessage(logLines, logFile);