Skip to content

Commit 6d7215a

Browse files
authored
Ungate CloudWatch Logs functionality (#1239)
Releasing CloudWatch Logs functionality by removing feature flag gating.
1 parent 7e10ce9 commit 6d7215a

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type": "Feature",
3+
"description": "CloudWatch Logs functionality"
4+
}

src/awsexplorer/regionNode.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import { SchemasNode } from '../eventSchemas/explorer/schemasNode'
88
import { CloudFormationNode } from '../lambda/explorer/cloudFormationNodes'
99
import { CloudWatchLogsNode } from '../cloudWatchLogs/explorer/cloudWatchLogsNode'
1010
import { LambdaNode } from '../lambda/explorer/lambdaNodes'
11-
import { ActiveFeatureKeys, FeatureToggle } from '../shared/featureToggle'
1211
import { S3Node } from '../s3/explorer/s3Nodes'
1312
import { DefaultS3Client } from '../shared/clients/defaultS3Client'
1413
import { Region } from '../shared/regions/endpoints'
@@ -45,11 +44,7 @@ export class RegionNode extends AWSTreeNodeBase {
4544
// This interface exists so we can add additional nodes to the array (otherwise Typescript types the array to what's already in the array at creation)
4645
const serviceCandidates = [
4746
{ serviceId: 'cloudformation', createFn: () => new CloudFormationNode(this.regionCode) },
48-
// Feature Toggle for CloudWatch Logs
49-
// REMOVE_WHEN_CLOUDWATCH_LOGS_READY
50-
...(FeatureToggle.getFeatureToggle().isFeatureActive(ActiveFeatureKeys.CloudWatchLogs)
51-
? [{ serviceId: 'logs', createFn: () => new CloudWatchLogsNode(this.regionCode) }]
52-
: []),
47+
{ serviceId: 'logs', createFn: () => new CloudWatchLogsNode(this.regionCode) },
5348
{ serviceId: 'lambda', createFn: () => new LambdaNode(this.regionCode) },
5449
{
5550
serviceId: 's3',

src/shared/featureToggle.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@ import { SettingsConfiguration, DefaultSettingsConfiguration } from './settingsC
1414
* You cannot have more active features than FeatureToggle.maxFeatures (default: 5)
1515
* Any features that are flagged in the code but not added here will always return false.
1616
*/
17-
export enum ActiveFeatureKeys {
18-
CloudWatchLogs = 'CloudWatchLogs',
19-
}
17+
export enum ActiveFeatureKeys {}
2018

2119
/**
2220
* This class handles feature access for unreleased or gated features.

0 commit comments

Comments
 (0)