feat: add centralized logging control using SAGEMAKER_CONTAINER_LOG_LEVEL #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EVEL - Implement centralized logging configuration that defaults to ERROR level - Use existing SAGEMAKER_CONTAINER_LOG_LEVEL (or LOG_LEVEL) environment variables - Migrate all 13 files to use centralized logger from logging_config - Add comprehensive unit tests for logging configuration - Update README with logging control documentation By default, package logging is effectively silent (ERROR level) unless explicitly configured via environment variables. This keeps production environments clean while allowing easy debugging when needed. Files migrated to centralized logger: - sagemaker/sagemaker_router.py - common/custom_code_ref_resolver/module_loader.py - common/fastapi/routing.py - common/custom_code_ref_resolver/file_loader.py - common/custom_code_ref_resolver/function_loader.py - sagemaker/sessions/transform.py - sagemaker/sessions/utils.py - sagemaker/sessions/handlers.py - common/transforms/base_factory.py - sagemaker/lora/transforms/__init__.py - sagemaker/lora/factory.py - common/handler/resolver.py - sagemaker/handler_resolver.py
Lokiiiiii
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, package logging is effectively silent (ERROR level) unless explicitly configured via environment variables. This keeps production environments clean while allowing easy debugging when needed.
Files migrated to centralized logger:
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.