Skip to content

Add support for $filter based /canAccess #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thgreasi wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add support for $filter based /canAccess #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/sbvr-api/permissions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import * as memoize from 'memoizee';
import * as randomstring from 'randomstring';
import * as env from '../config-loader/env';
import * as sbvrUtils from '../sbvr-api/sbvr-utils';
import { HookReq, addPureHook, addHook } from './hooks';
import { HookReq, addPureHook, addHook, HookArgs } from './hooks';
import {
BadRequestError,
PermissionError,
Expand Down Expand Up @@ -1595,9 +1595,8 @@ export const setup = () => {
POSTPARSE: async ({
req,
request,
}: {
req: HookReq;
request: ODataRequest & { permissionType?: PermissionCheck };
}: HookArgs & {
request: { permissionType?: PermissionCheck };
}) => {
// If the abstract sql query is already generated then adding permissions will do nothing
if (request.abstractSqlQuery != null) {
Expand All @@ -1607,7 +1606,10 @@ export const setup = () => {
request.method === 'POST' &&
request.odataQuery.property?.resource === 'canAccess'
) {
if (request.odataQuery.key == null) {
const { key } = request.odataQuery;
const $filter = request.odataQuery.options?.$filter;
if ((key == null) === ($filter == null)) {
// Exactly one of key or $filter are allowed
throw new BadRequestError();
}
const { action, method } = request.values;
Expand Down Expand Up @@ -1638,7 +1640,12 @@ export const setup = () => {
const idField = resourceTable.idField;
request.odataQuery.options = {
$select: { properties: [{ name: idField }] },
$top: 1,
...(key != null
? { $top: 1 }
: {
$filter,
$orderby: { properties: [{ name: idField, order: 'asc' }] },
}),
};
request.odataQuery.resource = request.resourceName;
delete request.odataQuery.property;
Expand Down