Skip to content

Commit 5f4f674

Browse files
author
Barthelemy Bonhomme
committed
chore: upgrades and global event types
1 parent 4424f59 commit 5f4f674

File tree

13 files changed

+1496
-1371
lines changed

13 files changed

+1496
-1371
lines changed

.github/workflows/npm-publish.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ on:
88
jobs:
99
publish-npm:
1010
runs-on: ubuntu-latest
11+
permissions:
12+
contents: read
13+
id-token: write
1114
steps:
1215
- uses: actions/checkout@v4
1316
- uses: actions/setup-node@v4

.yarn/releases/yarn-4.6.0.cjs

Lines changed: 0 additions & 934 deletions
This file was deleted.

.yarn/releases/yarn-4.9.3.cjs

Lines changed: 942 additions & 0 deletions
Large diffs are not rendered by default.

.yarnrc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
nodeLinker: node-modules
22

3-
yarnPath: .yarn/releases/yarn-4.6.0.cjs
3+
yarnPath: .yarn/releases/yarn-4.9.3.cjs

README.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,20 @@ Events dispatched on the slider's `element`:
262262

263263
You can use the proxy methods `addEventListener` and `removeEventListener` to listen to them.
264264

265+
If you want proper typing for these events in TypeScript, you can augment the global `HTMLElementEventMap` interface:
266+
267+
```ts
268+
declare global {
269+
interface HTMLElementEventMap {
270+
'slide-pass': CustomEvent<number>;
271+
'slide-stop': CustomEvent<number>;
272+
'slide-start': CustomEvent<number>;
273+
}
274+
}
275+
```
276+
277+
or copy/import them from `scroll-snap-slider/global.d.ts`.
278+
265279
## Public Properties
266280

267281
| Property | Description |

package.json

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "scroll-snap-slider",
3-
"version": "3.3.2",
3+
"version": "3.3.3",
44
"description": "Mostly CSS slider with great performance.",
55
"keywords": [
66
"slider",
@@ -31,23 +31,24 @@
3131
"author": "Barthy Bonhomme <[email protected]>",
3232
"license": "MIT",
3333
"devDependencies": {
34-
"@types/node": "^22.13.8",
35-
"@typescript-eslint/eslint-plugin": "^8.25.0",
36-
"@typescript-eslint/parser": "^8.25.0",
34+
"@microsoft/api-extractor": "^7.52.11",
35+
"@types/node": "^24.3.0",
36+
"@typescript-eslint/eslint-plugin": "^8.40.0",
37+
"@typescript-eslint/parser": "^8.40.0",
3738
"bash-echolorized": "^1.0.1",
38-
"core-js": "^3.40.0",
39-
"terser": "^5.39.0",
40-
"typedoc": "^0.27.9",
41-
"typescript": "^5.8.2",
42-
"vite": "5.4.6",
43-
"vite-plugin-dts": "^4.5.1"
39+
"core-js": "^3.45.1",
40+
"terser": "^5.43.1",
41+
"typedoc": "^0.28.10",
42+
"typescript": "^5.9.2",
43+
"unplugin-dts": "1.0.0-beta.0",
44+
"vite": "5.4.19"
4445
},
4546
"scripts": {
4647
"build:doc": "typedoc --tsconfig tsconfig.json --options ./typedoc.json src",
4748
"build:css": "mkdir -p dist && cp src/lib/scroll-snap-slider.css dist/scroll-snap-slider.css",
4849
"build:demo": "vite build --mode demo --base scroll-snap-slider && yarn build:doc",
49-
"build:lib": "vite build --mode lib && yarn build:css",
50+
"build:lib": "vite build --mode lib && yarn build:css && cp src/lib/*.d.ts dist/",
5051
"dev": "vite dev"
5152
},
52-
"packageManager": "yarn@4.6.0"
53+
"packageManager": "yarn@4.9.3"
5354
}

src/demo/slider-multi.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ScrollSnapSlider } from '../lib'
1+
import { ScrollSnapSlider } from 'scroll-snap-slider'
22

33
const sliderMultiElement = document.querySelector<HTMLElement>('.scroll-snap-slider.-multi')
44
const sliderMulti = new ScrollSnapSlider({ element: sliderMultiElement })

src/lib/ScrollSnapPlugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,4 @@ export abstract class ScrollSnapPlugin {
3232
*/
3333
public abstract disable (): void
3434

35-
}
35+
}

src/lib/ScrollSnapSlider.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,6 @@ export type ScrollSnapSliderOptions = Partial<ScrollSnapSlider> & {
77
element: HTMLElement
88
}
99

10-
declare global {
11-
interface HTMLElementEventMap {
12-
'slide-pass': CustomEvent<number>;
13-
'slide-stop': CustomEvent<number>;
14-
'slide-start': CustomEvent<number>;
15-
}
16-
}
17-
1810
/**
1911
* Mostly CSS slider with great performance.
2012
*/

src/lib/global.d.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
declare global {
2+
interface HTMLElementEventMap {
3+
'slide-pass': CustomEvent<number>;
4+
'slide-stop': CustomEvent<number>;
5+
'slide-start': CustomEvent<number>;
6+
}
7+
}
8+
9+
export {}

0 commit comments

Comments
 (0)