Skip recovery displays without photo url (#2995)

Author: sethherr

app/components/page_block/homepage_top/component.rb

@@ -5,31 +5,14 @@ class Component < ApplicationComponent
     def initialize(recoveries_value:, organization_count:, recovery_displays:)
       @recoveries_value = recoveries_value
       @organization_count = organization_count
-      @recovery_displays = recovery_displays
+      @recovery_displays = recovery_displays.select { it.photo_url.present? }
     end
 
     private
 
     def bike_tile_images
-      [
-        "redesign_2025/bike_tiles/bike-entry_0000.png",
-        "redesign_2025/bike_tiles/bike-entry_0001.png",
-        "redesign_2025/bike_tiles/bike-entry_0002.png",
-        "redesign_2025/bike_tiles/bike-entry_0003.png",
-        "redesign_2025/bike_tiles/bike-entry_0004.png",
-        "redesign_2025/bike_tiles/bike-entry_0005.png",
-        "redesign_2025/bike_tiles/bike-entry_0006.png",
-        "redesign_2025/bike_tiles/bike-entry_0007.png",
-        "redesign_2025/bike_tiles/bike-entry_0008.png",
-        "redesign_2025/bike_tiles/bike-entry_0009.png",
-        "redesign_2025/bike_tiles/bike-entry_0010.png",
-        "redesign_2025/bike_tiles/bike-entry_0011.png",
-        "redesign_2025/bike_tiles/bike-entry_0012.png",
-        "redesign_2025/bike_tiles/bike-entry_0013.png",
-        "redesign_2025/bike_tiles/bike-entry_0014.png",
-        "redesign_2025/bike_tiles/bike-entry_0015.png",
-        "redesign_2025/bike_tiles/bike-entry_0016.png"
-      ].map { image_url(it) }
+      (0..16).map { it.to_s.rjust(2, "0") }
+        .map { image_url("redesign_2025/bike_tiles/bike-entry_00#{it}.png") }
     end
 
     def recoveries_value

app/javascript/controllers/admin/recovery_display_form_controller.js

@@ -23,7 +23,7 @@ export default class extends Controller {
   connect () {
     this.setCharacterCount()
 
-    if (this.toggleImageValue) {
+    if (this.usingBikeImageTargets.length > 0) {
       this.toggleBikeImageForDisplay()
     }
   }

app/views/admin/recovery_displays/_form.html.erb

@@ -190,6 +190,7 @@
               </span>
 
               <span
+                class="tw:hidden"
                 data-admin--recovery-display-form-target="notUsingBikeImage"
               >
                 <%= @bike.type_titleize %>
@@ -208,6 +209,7 @@
                 href="#"
               >
                 <span
+                  class="tw:hidden"
                   data-admin--recovery-display-form-target="notUsingBikeImage"
                 >
                   Use first image