Skip to content

Conversation

@allen0099
Copy link

Summary

This pull request introduces a conditional check to the download_cli.sh script, improving how the script handles adding GOOSE_BIN_DIR to the user's PATH. The main change is that the script now respects a CONFIGURE flag, which allows users to skip interactive configuration and receive manual instructions instead.

Enhancements to PATH configuration logic:

  • Added a check for the CONFIGURE environment variable to determine whether to prompt the user interactively or simply show manual instructions for adding GOOSE_BIN_DIR to the PATH.
  • If CONFIGURE is not enabled, the script now displays a message indicating that configuration is disabled and instructs the user to add GOOSE_BIN_DIR manually.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

AI Assistance

  • This PR was created or reviewed with AI assistance

Copilot AI review requested due to automatic review settings December 2, 2025 05:54
Copilot finished reviewing on behalf of allen0099 December 2, 2025 05:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the download_cli.sh script by adding conditional handling for the CONFIGURE environment variable when prompting users to add GOOSE_BIN_DIR to their PATH. This aligns the PATH configuration behavior with the existing goose configure step (line 290), allowing non-interactive installations to skip prompts entirely.

  • Wraps the interactive PATH configuration prompt in a CONFIGURE check
  • Displays a simple message when configuration is disabled, prompting manual PATH setup

esac
else
echo ""
echo "Configure disabled. Please add \$GOOSE_BIN_DIR to your PATH manually."
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When CONFIGURE is disabled, users don't receive instructions on how to manually add GOOSE_BIN_DIR to their PATH. Consider showing the same instructions as choice "2" (lines 341-344) so users know the exact command to run.

Suggested change
echo "Configure disabled. Please add \$GOOSE_BIN_DIR to your PATH manually."
echo "Configure disabled. Please add \$GOOSE_BIN_DIR to your PATH manually."
echo ""
echo "Add it to your PATH by editing ~/.${SHELL_NAME}rc or similar:"
echo " export PATH=\"\$GOOSE_BIN_DIR:\$PATH\""
echo "Then reload your shell (e.g. 'source ~/.${SHELL_NAME}rc') to apply changes."

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant