Allow customizing the new line keybinding in the CLI #5956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trae Robrock <[email protected]>
trobrock
force-pushed
the
custom-new-line-key
branch
from
be28b3b to
e8fdc51
Compare
Copilot finished reviewing on behalf of
trobrock
December 3, 2025 00:46
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds customization support for the CLI newline keybinding through the GOOSE_CLI_NEWLINE_KEY environment variable, allowing users to change from the default Ctrl+J to any other Ctrl+ combination.
Key Changes
- Added
get_newline_key()function to read and validate the environment variable with sensible defaults - Updated all user-facing documentation (system prompt, help text, and comments) to reflect the customizable keybinding
- Added comprehensive unit tests covering default behavior, custom keys, edge cases (empty strings, multi-char strings, case conversion)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/goose-cli/src/session/input.rs | Implements the configurable keybinding logic, updates help text, and adds unit tests |
| crates/goose-cli/src/session/prompt.rs | Updates the system prompt to dynamically show the configured keybinding |
Signed-off-by: Trae Robrock <[email protected]>
trobrock
force-pushed
the
custom-new-line-key
branch
from
7d54e73 to
7c0bff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows the customization of the kebinding in the CLI to be customized using the
GOOSE_CLI_NEWLINE_KEY.For example (CTRL-N will enter a newline):
Type of Change
AI Assistance
Testing
Unit tests have been added.
I also manually tested this.