Implement fast unwinding using ghost unwind #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Galindo <[email protected]>
Signed-off-by: Pablo Galindo <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
==========================================
- Coverage 92.50% 91.97% -0.53%
==========================================
Files 99 100 +1
Lines 11697 11877 +180
Branches 426 429 +3
==========================================
+ Hits 10820 10924 +104
- Misses 877 953 +76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pablogsal
force-pushed
the
fast_unwind
branch
from
94719ec to
1903e78
Compare
pablogsal
force-pushed
the
fast_unwind
branch
from
e183e30 to
1588be9
Compare
Signed-off-by: Pablo Galindo <[email protected]>
pablogsal
force-pushed
the
fast_unwind
branch
2 times, most recently
from
6f8291b to
09b458b
Compare
On ARM64, the first frame(s) returned by libunwind's cursor iteration could have invalid ret_loc values pointing into our own active stack frame. Writing the trampoline address to these locations corrupted our execution state, causing crashes. Root cause: On ARM64, unw_get_save_loc() for the link register (X30) returns the location where LR was saved by the function prologue. For our internal frames (capture_and_install, ghost_stack_backtrace), these locations were still being used during execution. Additionally, fixed the expected_sp calculation for ARM64 longjmp detection. On x86_64, RET pops the return address so SP = ret_loc + 8. On ARM64, RET doesn't touch SP - the epilogue restores it beforehand. The trampoline receives the actual SP value, not ret_loc + 8.
… frames Signed-off-by: Pablo Galindo <[email protected]>
pablogsal
force-pushed
the
fast_unwind
branch
from
488fd8a to
acdcf94
Compare
pablogsal
force-pushed
the
fast_unwind
branch
from
0321688 to
ea497f3
Compare
pablogsal
force-pushed
the
fast_unwind
branch
from
85a6c5a to
0e825b2
Compare
Signed-off-by: Pablo Galindo <[email protected]>
pablogsal
force-pushed
the
fast_unwind
branch
from
13f0283 to
0d1e1c1
Compare
pablogsal
force-pushed
the
fast_unwind
branch
from
3e9ed04 to
09d02ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pablo Galindo [email protected]