Move from legacy proxy to gateway#191
Merged
Merged
Conversation
Braintrust eval reportEvals failed: Error: Command failed with exit code 1 |
|
|
||
| self._is_wrapped = isinstance(self.openai, NamedWrapper) | ||
| self._is_wrapped = isinstance(self.openai, NamedWrapper) or ( | ||
| not has_customization and wrap_openai.__module__.startswith("braintrust.") |
Contributor
Author
There was a problem hiding this comment.
drive-by, the test was broken
Olmo Maldonado (ibolmo)
approved these changes
Jun 1, 2026
Olmo Maldonado (ibolmo)
left a comment
Olmo Maldonado (ibolmo)
left a comment
Collaborator
There was a problem hiding this comment.
just various nits, but none blocking. i wonder if you'd want to. bump the version as either minor or major. i'd ask in sdk channel.
| } | ||
|
|
||
| const PROXY_URL = "https://api.braintrust.dev/v1/proxy"; | ||
| const GATEWAY_URL = "https://gateway.braintrust.dev"; |
Collaborator
There was a problem hiding this comment.
(i know it's outside of your change, but) we should move to an env var, and default to this.
| * | ||
| * @example | ||
| * // Using with Anthropic via Braintrust proxy | ||
| * // Using with Anthropic via Braintrust Gateway |
Collaborator
There was a problem hiding this comment.
#nit Braintrust AI Gateway? what's the official product name? 🤔
Contributor
Author
There was a problem hiding this comment.
Braintrust Gateway -- https://www.braintrust.dev/docs/deploy/gateway
| # Configure client to use the Braintrust Gateway with Claude | ||
| client = AsyncOpenAI( | ||
| base_url="https://api.braintrust.dev/v1/proxy", | ||
| base_url="https://gateway.braintrust.dev", |
Collaborator
There was a problem hiding this comment.
ditto os.getenv('BRAINTRUST_AI_GATEWAY_URL') or 'https://...'
| from typing import Any, Optional, Protocol, TypedDict, TypeVar, Union, cast, runtime_checkable | ||
|
|
||
| PROXY_URL = "https://api.braintrust.dev/v1/proxy" | ||
| GATEWAY_URL = "https://gateway.braintrust.dev" |
Collaborator
There was a problem hiding this comment.
Olmo Maldonado (ibolmo)
approved these changes
Jun 2, 2026
Olmo Maldonado (ibolmo)
left a comment
Olmo Maldonado (ibolmo)
left a comment
Collaborator
There was a problem hiding this comment.
nothing blocking, ty!
| const DEFAULT_GATEWAY_URL = "https://gateway.braintrust.dev"; | ||
|
|
||
| const getGatewayURL = (): string => | ||
| process.env.BRAINTRUST_AI_GATEWAY_URL || DEFAULT_GATEWAY_URL; |
Collaborator
There was a problem hiding this comment.
I'd encourage a sanitizing like:
(process.env.BRAINTRUST_AI_GATEWAY_URL ?? '').trim() || DEFAULT_GATEWAY_URL
|
|
||
|
|
||
| def test_prepare_openai_defaults_to_gateway(monkeypatch: pytest.MonkeyPatch): | ||
| monkeypatch.delenv("OPENAI_BASE_URL", raising=False) |
Collaborator
There was a problem hiding this comment.
(fyi) i like to use getEnv() and similar helpers to avoid monkey patching. you can then just set/unset env vars more easily.
Contributor
Author
There was a problem hiding this comment.
makes sense!
Abhijeet Prasad (AbhiPrasad)
approved these changes
Jun 8, 2026
Erin McNulty (erin2722)
force-pushed
the
move-to-gateway
branch
from
0671f6e to
3177421
Compare
Braintrust eval report
|
Braintrust eval report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AI Proxy will be deprecated soon, and the AI Gateway is being continually updated with bug fixes and new features, and so we should move this repository to use that.