Skip to content

Commit 5513d52

Browse files
authored
Merge pull request #727 from SerhiiDenysov/rxjava3
appyx ribs-interop switched to rxjava3 compatible version
2 parents 917963a + b6b12a6 commit 5513d52

File tree

22 files changed

+67
-68
lines changed

22 files changed

+67
-68
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Pending changes
44

5-
-
5+
- [#727](https://github.com/bumble-tech/appyx/pull/727)**Updated**: Ribs to 0.41.0 and MVICore to 2.0.0
66

77
## 1.6.0
88

gradle/libs.versions.toml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ androidx-navigation-compose = "2.5.1"
1010
androidx-tracing = "1.2.0"
1111
coil = "2.2.1"
1212
composeBom = "2024.12.01"
13-
ribs = "0.39.0"
14-
mvicore = "1.2.6"
13+
ribs = "0.41.0"
14+
mvicore = "2.0.0"
1515
coroutines = "1.9.0-RC.2"
1616
kotlin = "2.0.20"
1717
junit5 = "5.8.2"
@@ -57,12 +57,11 @@ mvicore-binder = { module = "com.github.badoo.mvicore:binder", version.ref = "mv
5757
ribs-base = { module = "com.github.badoo.RIBs:rib-base", version.ref = "ribs" }
5858
ribs-base-test = { module = "com.github.badoo.RIBs:rib-base-test", version.ref = "ribs" }
5959
ribs-base-test-activity = { module = "com.github.badoo.RIBs:rib-base-test-activity", version.ref = "ribs" }
60-
ribs-base-test-rx2 = { module = "com.github.badoo.RIBs:rib-base-test-rx2", version.ref = "ribs" }
60+
ribs-base-test-rx3 = { module = "com.github.badoo.RIBs:rib-base-test-rx3", version.ref = "ribs" }
6161
ribs-compose = { module = "com.github.badoo.RIBs:rib-compose", version.ref = "ribs" }
6262

6363
rxjava2 = "io.reactivex.rxjava2:rxjava:2.2.21"
64-
rxjava3 = "io.reactivex.rxjava3:rxjava:3.1.5"
65-
rxandroid2 = "io.reactivex.rxjava2:rxandroid:2.1.1"
64+
rxjava3 = "io.reactivex.rxjava3:rxjava:3.1.10"
6665
rxandroid3 = "io.reactivex.rxjava3:rxandroid:3.0.2"
6766
rxrelay2 = "com.jakewharton.rxrelay2:rxrelay:2.1.1"
6867
rxrelay3 = "com.jakewharton.rxrelay3:rxrelay:3.0.1"

samples/sandbox/build.gradle.kts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ dependencies {
6060

6161
implementation(composeBom)
6262
implementation(project(":libraries:core"))
63-
implementation(project(":libraries:interop-rx2"))
63+
implementation(project(":libraries:interop-rx3"))
6464
implementation(project(":libraries:interop-ribs"))
6565
implementation(project(":samples:navmodel-samples"))
6666
implementation(project(":samples:common"))
@@ -80,9 +80,9 @@ dependencies {
8080
implementation(libs.mvicore.base)
8181
implementation(libs.mvicore.android)
8282
implementation(libs.mvicore.binder)
83-
implementation(libs.rxjava2)
84-
implementation(libs.rxandroid2)
85-
implementation(libs.rxrelay2)
83+
implementation(libs.rxjava3)
84+
implementation(libs.rxandroid3)
85+
implementation(libs.rxrelay3)
8686
implementation(libs.toolargetool)
8787

8888
testImplementation(libs.androidx.arch.core.testing)
@@ -93,7 +93,7 @@ dependencies {
9393
testImplementation(project(":libraries:testing-junit4"))
9494
testImplementation(project(":libraries:testing-junit5"))
9595
testImplementation(libs.ribs.base.test)
96-
testImplementation(libs.ribs.base.test.rx2)
96+
testImplementation(libs.ribs.base.test.rx3)
9797

9898
androidTestImplementation(composeBom)
9999
androidTestImplementation(libs.androidx.test.espresso.core)

samples/sandbox/src/androidTest/kotlin/com/bumble/appyx/sandbox/client/test/AppyxMviViewTestRule.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ package com.bumble.appyx.sandbox.client.test
33
import com.bumble.appyx.core.node.NodeView
44
import com.bumble.appyx.core.node.ViewFactory
55
import com.bumble.appyx.testing.ui.rules.AppyxViewTestRule
6-
import io.reactivex.ObservableSource
7-
import io.reactivex.functions.Consumer
8-
import io.reactivex.observers.TestObserver
6+
import io.reactivex.rxjava3.core.ObservableSource
7+
import io.reactivex.rxjava3.functions.Consumer
8+
import io.reactivex.rxjava3.observers.TestObserver
99

1010
class AppyxMviViewTestRule<ViewModel : Any, Event : Any, View : NodeView>(
1111
private val modelConsumer: (View) -> Consumer<in ViewModel>,

samples/sandbox/src/androidTest/kotlin/com/bumble/appyx/sandbox/client/test/AppyxViewRules.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ package com.bumble.appyx.sandbox.client.test
22

33
import com.bumble.appyx.core.node.NodeView
44
import com.bumble.appyx.core.node.ViewFactory
5-
import io.reactivex.ObservableSource
6-
import io.reactivex.functions.Consumer
5+
import io.reactivex.rxjava3.core.ObservableSource
6+
import io.reactivex.rxjava3.functions.Consumer
77

88
fun <ViewModel : Any, Event : Any, View> appyxViewRule(
99
viewFactory: ViewFactory<View>,
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
package com.bumble.appyx.sandbox.client.test
22

3-
import io.reactivex.Observable
4-
import io.reactivex.ObservableSource
5-
import io.reactivex.observers.TestObserver
3+
import io.reactivex.rxjava3.core.Observable
4+
import io.reactivex.rxjava3.core.ObservableSource
5+
import io.reactivex.rxjava3.observers.TestObserver
66
import org.hamcrest.MatcherAssert.assertThat
77
import org.hamcrest.Matchers.greaterThan
88

9-
fun <T> ObservableSource<out T>.wrapToObservable(): Observable<T> = Observable.wrap(cast())
9+
fun <T : Any> ObservableSource<out T>.wrapToObservable(): Observable<T> = Observable.wrap(cast())
1010

1111
inline fun <reified T> Any?.cast(): T = this as T
1212

13-
fun <T> TestObserver<T>.assertLastValueEqual(value: T) {
14-
assertThat(this.valueCount(), greaterThan(0))
15-
this.assertValueAt(valueCount() - 1, value)
13+
fun <T : Any> TestObserver<T>.assertLastValueEqual(value: T) {
14+
assertThat(this.values().size, greaterThan(0))
15+
this.assertValueAt(values().size - 1, value)
1616
}

samples/sandbox/src/main/kotlin/com/bumble/appyx/sandbox/client/interop/parent/RibsParentInteractor.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import com.badoo.ribs.routing.source.backstack.BackStack
88
import com.badoo.ribs.routing.source.backstack.operation.push
99
import com.bumble.appyx.sandbox.client.interop.parent.routing.RibsParentRouter.Configuration
1010
import com.bumble.appyx.sandbox.client.interop.parent.RibsParentView.Event
11-
import io.reactivex.functions.Consumer
11+
import io.reactivex.rxjava3.functions.Consumer
1212

1313
internal class RibsParentInteractor(
1414
private val backStack: BackStack<Configuration>,

samples/sandbox/src/main/kotlin/com/bumble/appyx/sandbox/client/interop/parent/RibsParentView.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ import com.badoo.ribs.core.view.ViewFactoryBuilder
1212
import com.bumble.appyx.R
1313
import com.bumble.appyx.sandbox.client.interop.parent.RibsParentView.Event
1414
import com.bumble.appyx.sandbox.client.interop.parent.RibsParentView.Event.SwitchClicked
15-
import com.jakewharton.rxrelay2.PublishRelay
16-
import io.reactivex.ObservableSource
15+
import com.jakewharton.rxrelay3.PublishRelay
16+
import io.reactivex.rxjava3.core.ObservableSource
1717

1818
interface RibsParentView : RibView, ObservableSource<Event> {
1919

samples/sandbox/src/main/kotlin/com/bumble/appyx/sandbox/client/mvicoreexample/MviCoreChildNode1.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import androidx.compose.runtime.Composable
99
import androidx.compose.ui.Alignment
1010
import androidx.compose.ui.Modifier
1111
import androidx.compose.ui.graphics.Color
12-
import com.bumble.appyx.interop.rx2.connectable.Connectable
13-
import com.bumble.appyx.interop.rx2.connectable.NodeConnector
12+
import com.bumble.appyx.interop.rx3.connectable.Connectable
13+
import com.bumble.appyx.interop.rx3.connectable.NodeConnector
1414
import com.bumble.appyx.core.modality.BuildContext
1515
import com.bumble.appyx.core.node.Node
1616
import com.bumble.appyx.sandbox.client.mvicoreexample.MviCoreChildNode1.Input

samples/sandbox/src/main/kotlin/com/bumble/appyx/sandbox/client/mvicoreexample/MviCoreChildNode2.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import androidx.compose.runtime.Composable
99
import androidx.compose.ui.Alignment
1010
import androidx.compose.ui.Modifier
1111
import androidx.compose.ui.graphics.Color
12-
import com.bumble.appyx.interop.rx2.connectable.Connectable
13-
import com.bumble.appyx.interop.rx2.connectable.NodeConnector
12+
import com.bumble.appyx.interop.rx3.connectable.Connectable
13+
import com.bumble.appyx.interop.rx3.connectable.NodeConnector
1414
import com.bumble.appyx.core.modality.BuildContext
1515
import com.bumble.appyx.core.node.Node
1616
import com.bumble.appyx.sandbox.client.mvicoreexample.MviCoreChildNode2.Input

0 commit comments

Comments
 (0)