Avoid emitting redundant #[allow(dead_code)] directives.
#1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only emit `#[allow(dead_code)]` on top-level modules, and emit `#[rustfmt::skip]` on all top-level modules.
pchickey
approved these changes
Nov 18, 2024
sunfishcode
added a commit
to sunfishcode/wit-bindgen
that referenced
this pull request
Nov 20, 2024
Effectively revert bytecodealliance#1089, and go back to putting `#[allow(dead_code)]` on all modules for now, because the code in bytecodealliance#1089 didn't work for interfaces defined inline inside of worlds, which turn into top-level modules in the Rust bindings.
sunfishcode
added a commit
to sunfishcode/wit-bindgen
that referenced
this pull request
Nov 20, 2024
Effectively revert bytecodealliance#1089, and go back to putting `#[allow(dead_code)]` on all modules for now, because the code in bytecodealliance#1089 didn't work for interfaces defined inline inside of worlds, which turn into top-level modules in the Rust bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only emit
#[allow(dead_code)]on top-level modules, and emit#[rustfmt::skip]on all top-level modules.