Skip to content

Commit d1c7557

Browse files
fnothaftCJ
authored andcommitted
Parametrized quinine-pipelines Dockerfile to pick up changes to quinine.
1 parent 79482a7 commit d1c7557

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed

quinine-pipelines/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
Dockerfile
12
*.workflow.json
23
cromwell-*
34
WorkflowStore
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM quay.io/ucsc_cgl/quinine
1+
FROM quay.io/ucsc_cgl/quinine:QUININE_TAG
22

33
MAINTAINER Frank Austin Nothaft, [email protected]
44

quinine-pipelines/Makefile

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
# Definitions
22
runtime_fullpath = $(realpath runtime)
33
build_tool = runtime-container.DONE
4-
git_commit ?= $(shell git log --pretty=oneline -n 1 -- ../quinine-pipelines | cut -f1 -d " ")
4+
git_commit ?= $(shell git log --pretty=oneline -n 1 -- ../quinine-pipelines ../quinine | cut -f1 -d " ")
55
name = quay.io/ucsc_cgl/quinine-pipelines
66
tag = 716dd26cf6252a6db60afa25aaf7cf9ee9896b21--${git_commit}
7-
7+
quinine_tag = $(shell cd ../quinine && make print_tag)
88
workflows = contamination.workflow.json rna.workflow.json targeted.workflow.json
99

10-
build:
10+
Dockerfile: Dockerfile.template
11+
sed -e "s:QUININE_TAG:${quinine_tag}:g" Dockerfile.template > Dockerfile
12+
13+
build: Dockerfile
1114
docker build -t ${name}:${tag} .
1215
docker tag -f ${name}:${tag} ${name}:latest
1316
touch ${build_tool}
@@ -24,4 +27,4 @@ test: build ${workflows}
2427
sed -e "s:PWD:${PWD}:g" $< > $@
2528

2629
clean:
27-
-rm ${build_tool} *.workflow.json
30+
-rm ${build_tool} *.workflow.json Dockerfile

quinine/Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ clean:
2929
rm -rf runtime/quinine ${build_tool}
3030
docker rmi -f ${name}-build:${tag} ${name}:${tag}
3131

32+
print_tag:
33+
@echo ${tag}
34+
3235
push: build
3336
# Requires ~/.dockercfg
3437
docker push ${name}:${tag}

0 commit comments

Comments
 (0)