consoleCatcher init #116
Merged
consoleCatcher init #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
reviewed
Mar 15, 2025
src/addons/consoleCatcher.ts
Outdated
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| args: any; | ||
| } | ||
| import type { ConsoleLogEvent } from '@hawk.so/types/build/src/base/event/addons/javascript'; |
Member
There was a problem hiding this comment.
Suggested change
| import type { ConsoleLogEvent } from '@hawk.so/types/build/src/base/event/addons/javascript'; | |
| import type { ConsoleLogEvent } from '@hawk.so/types'; |
src/addons/consoleCatcher.ts
Outdated
| }; | ||
| }); | ||
|
|
||
| window.addEventListener('error', function (event) { |
Member
There was a problem hiding this comment.
think how we can reuse existing catcher errors
src/addons/consoleCatcher.ts
Outdated
| import type { ConsoleLogEvent } from '@hawk.so/types/build/src/base/event/addons/javascript'; | ||
|
|
||
| const MAX_LOGS = 20; | ||
| const consoleOutput: ConsoleLogEvent[] = []; |
Member
There was a problem hiding this comment.
can we use scoped variable instead of global?
e11sy
reviewed
Mar 16, 2025
Contributor
e11sy
left a comment
e11sy
left a comment
There was a problem hiding this comment.
fix bug in repetitions
and bump package version
e11sy
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed?