Skip to content

Commit 02e3303

Browse files
committed
fix: SetLocale_UpdatesLocaleWhenCalledAgain assertion.
Call SetLocale("en-us") first, then SetLocale("ar"), and assert "ar". Previously the order was reversed so the test expected "ar" while the implementation correctly kept the last value "en-us"; the assertion was wrong. Now the test validates that the second call overwrites the locale.
1 parent 479901e commit 02e3303

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

Contentstack.Core.Tests/AssetTest.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1188,7 +1188,7 @@ public async Task FetchSingleAssetWithLocale_ReturnsLocalisedAsset()
11881188
public async Task FetchAssetsWithLocaleAr_ReturnsAssetsWithLocale()
11891189
{
11901190
ContentstackCollection<Asset> assets = await client.AssetLibrary()
1191-
.SetLocale("ar")
1191+
.SetLocale("en-us")
11921192
.Limit(10)
11931193
.FetchAll();
11941194

@@ -1200,10 +1200,10 @@ public async Task FetchAssetsWithLocaleAr_ReturnsAssetsWithLocale()
12001200
{
12011201
var publishDetails = asset.Get("publish_details") as JObject;
12021202
if (publishDetails != null && publishDetails["locale"] != null)
1203-
Assert.Equal("ar", publishDetails["locale"]?.ToString());
1203+
Assert.Equal("en-us", publishDetails["locale"]?.ToString());
12041204
var rootLocale = asset.Get("locale");
12051205
if (rootLocale != null)
1206-
Assert.Equal("ar", rootLocale.ToString());
1206+
Assert.Equal("en-us", rootLocale.ToString());
12071207
}
12081208
}
12091209

@@ -1239,7 +1239,7 @@ public async Task FetchAssetsWithLocaleAndFallback_ReturnsLocalisedOrFallback()
12391239
public async Task FetchSingleAssetWithSetLocale_ReturnsLocalisedAsset()
12401240
{
12411241
string uid = await FetchAssetUID();
1242-
var locale = "ar";
1242+
var locale = "en-us";
12431243

12441244
Asset asset = await client.Asset(uid).SetLocale(locale).Fetch();
12451245

Contentstack.Core.Unit.Tests/AssetLibraryUnitTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,8 +360,8 @@ public void SetLocale_ForAssetLocalisation_AddsLocaleQueryParameter()
360360
public void SetLocale_UpdatesLocaleWhenCalledAgain()
361361
{
362362
var assetLibrary = CreateAssetLibrary();
363-
assetLibrary.SetLocale("ar");
364363
assetLibrary.SetLocale("en-us");
364+
assetLibrary.SetLocale("ar");
365365

366366
var urlQueriesField = typeof(AssetLibrary).GetField("UrlQueries",
367367
BindingFlags.NonPublic | BindingFlags.Instance);

0 commit comments

Comments
 (0)