Fix #14518 FP KnownConditionTrueFalse: std::string constructed from char array (#8242)

Author: chrchr-github

lib/valueflow.cpp

@@ -6494,7 +6494,7 @@ static std::vector<ValueFlow::Value> getContainerSizeFromConstructorArgs(const s
             if (args.size() == 1 && args[0]->tokType() == Token::Type::eString)
                 return {makeContainerSizeValue(Token::getStrLength(args[0]), known)};
             if (args.size() == 1 && args[0]->variable() && args[0]->variable()->isArray() &&
-                args[0]->variable()->isConst() && args[0]->variable()->dimensions().size() == 1)
+                args[0]->variable()->isConst() && args[0]->variable()->dimensions().size() == 1 && args[0]->variable()->dimensions()[0].known)
                 return {makeContainerSizeValue(args[0]->variable()->dimensions()[0].num, known)};
             if (args.size() == 2 && astIsIntegral(args[1], false)) // { char*, count }
                 return {makeContainerSizeValue(args[1], known)};

test/testvalueflow.cpp

@@ -7406,6 +7406,12 @@ class TestValueFlow : public TestFixture {
                "    return a[0];\n"
                "}";
         ASSERT(!isKnownContainerSizeValue(tokenValues(code, "a ["), 6).empty());
+
+        code = "void f(const char a[]) {\n" // #14518
+               "    std::string s(a);\n"
+               "    if (s.empty()) {}\n"
+               "}";
+        ASSERT(!isKnownContainerSizeValue(tokenValues(code, "s ."), 0).empty());
     }
 
     void valueFlowContainerElement()