Skip to content

Commit 1317c98

Browse files
praiskupkdudka
authored andcommitted
csfilter: allow line shift in PyLint method re-definition message
See Zuul failure in: https://pagure.io/copr/copr/pull-request/1749# Closes: https://github.com/kdudka/csdiff/pull/17
1 parent bbe6142 commit 1317c98

File tree

3 files changed

+28
-0
lines changed

3 files changed

+28
-0
lines changed

src/csfilter.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,10 @@ MsgFilter::MsgFilter():
121121

122122
// "... Redefining name 'desc' from outer scope (line 10)" etc.
123123
d->addMsgFilter(checker, " \\((?:imported )?line [0-9]+\\)$", "");
124+
125+
// ".. method already defined line 199"
126+
d->addMsgFilter(checker, " method already defined line [0-9]+$",
127+
" method already defined");
124128
}
125129

126130
// "__coverity_strcmp" -> "strcmp", etc.

tests/csdiff/diff-misc/11-pylint-copr-json-new.err

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12132,6 +12132,18 @@
1213212132
}
1213312133
]
1213412134
},
12135+
{
12136+
"checker": "PYLINT_WARNING",
12137+
"events": [
12138+
{
12139+
"file_name": "coprs_frontend/tests/test_apiv3/test_projects.py",
12140+
"line": 219,
12141+
"column": 4,
12142+
"event": "E0102[function-redefined]",
12143+
"message": "TestApiV3Permissions.test_perms_set_sends_emails: method already defined line 199"
12144+
}
12145+
]
12146+
},
1213512147
{
1213612148
"checker": "PYLINT_WARNING",
1213712149
"events": [

tests/csdiff/diff-misc/11-pylint-copr-json-old.err

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12168,6 +12168,18 @@
1216812168
}
1216912169
]
1217012170
},
12171+
{
12172+
"checker": "PYLINT_WARNING",
12173+
"events": [
12174+
{
12175+
"file_name": "coprs_frontend/tests/test_apiv3/test_projects.py",
12176+
"line": 222,
12177+
"column": 5,
12178+
"event": "E0102[function-redefined]",
12179+
"message": "TestApiV3Permissions.test_perms_set_sends_emails: method already defined line 202"
12180+
}
12181+
]
12182+
},
1217112183
{
1217212184
"checker": "PYLINT_WARNING",
1217312185
"events": [

0 commit comments

Comments
 (0)