Skip to content

Commit 73fb2a5

Browse files
committed
ci: trigger Node.js integration tests on KERNEL_REV / native changes
The merge-queue gate (merge-queue-nodejs) and the labeled-PR preview (trigger-tests-pr) both classify a change as "driver changes" via a path allow-list that omitted KERNEL_REV and native/. A PR whose only relevant change is a KERNEL_REV bump (or a native/kernel/** binding change) was therefore detected as "no driver files changed" and auto-passed the required "Node.js Integration Tests" check WITHOUT running anything — i.e. the kernel integration suite was skipped for exactly the PRs that swap the pinned kernel. driver-test already builds the napi binding from the driver's KERNEL_REV at the dispatched commit, so once these changes trigger a dispatch the merge-queue run exercises the integration tests against the pinned kernel version. Add native/ and KERNEL_REV to both detectors so kernel bumps are gated. Co-authored-by: Isaac Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
1 parent 1e892cf commit 73fb2a5

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/trigger-integration-tests.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,8 @@ jobs:
152152
file.startsWith('thrift/') ||
153153
file.startsWith('tests/e2e/') ||
154154
file.startsWith('tests/integration/') ||
155+
file.startsWith('native/') ||
156+
file === 'KERNEL_REV' ||
155157
file === 'package.json' ||
156158
file === 'package-lock.json' ||
157159
file === 'tsconfig.json' ||
@@ -274,7 +276,7 @@ jobs:
274276
HEAD_SHA: ${{ github.event.merge_group.head_sha }}
275277
run: |
276278
CHANGED=$(git diff --name-only "$BASE_SHA" "$HEAD_SHA")
277-
if echo "$CHANGED" | grep -qE "^(bin/|lib/|spec/|thrift/|tests/e2e/|tests/integration/|package\.json|package-lock\.json|tsconfig(\.build)?\.json|\.github/workflows/)"; then
279+
if echo "$CHANGED" | grep -qE "^(bin/|lib/|spec/|thrift/|tests/e2e/|tests/integration/|native/|KERNEL_REV$|package\.json|package-lock\.json|tsconfig(\.build)?\.json|\.github/workflows/)"; then
278280
echo "changed=true" >> "$GITHUB_OUTPUT"
279281
echo "Driver files changed - will dispatch Node.js integration tests"
280282
else

0 commit comments

Comments
 (0)