dbeaver/cloudbeaver#4138 feat: support inline editing of multi-line v…#4341
Merged
devnaumov merged 7 commits intoMay 20, 2026
Merged
Conversation
…cells
- TextEditor: switch <input> to <textarea rows=1> so newlines are preserved when editing. Suppress the trailing insertLineBreak from the Enter that opens the editor (would otherwise wipe the auto-selected value).
- ResultSetFormatAction.truncateText: substitute \n, \r, \r\n, \t with
visible glyphs (↵, ␍, →) and collapse other control chars to a space
in a single pass.
Perf note: the new replace should be faster than the prior
split('') + map + join. No intermediate array allocations, and the
callback runs only on matched chars (which are sparse in display text). \p{Cc} also expands coverage from charCode < 32 to include DEL and C1 controls (U+007F, U+0080–U+009F). (closer to Dbeaver behavior)
Contributor
Author
Screen.Recording.2026-05-14.at.10.30.05.mov |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
sergeyteleshev
previously approved these changes
May 14, 2026
devnaumov
previously approved these changes
May 14, 2026
SychevAndrey
dismissed stale reviews from devnaumov and sergeyteleshev
via
95d4dec
devnaumov
approved these changes
May 20, 2026
…use-update-problems
sergeyteleshev
approved these changes
May 20, 2026
devnaumov
deleted the
4138-the-interface-may-be-misleading-and-cause-update-problems
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…alues in data grid cells
Perf note: the new replace should be faster than the prior split('') + map + join. No intermediate array allocations, and the callback runs only on matched chars (which are sparse in display text). \p{Cc} also expands coverage from charCode < 32 to include DEL and C1 controls (U+007F, U+0080–U+009F). (closer to Dbeaver behavior)