Skip to content

Commit 3afb315

Browse files
authored
fix(hub-ui): make json-render an optional peer (#235)
1 parent c0dfc1f commit 3afb315

2 files changed

Lines changed: 11 additions & 1 deletion

File tree

packages/hub-ui/package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,11 @@
4545
"@devframes/json-render": "workspace:*",
4646
"devframe": "workspace:*"
4747
},
48+
"peerDependenciesMeta": {
49+
"@devframes/json-render": {
50+
"optional": true
51+
}
52+
},
4853
"devDependencies": {
4954
"@antfu/design": "catalog:frontend",
5055
"@devframes/hub": "workspace:*",

packages/hub-ui/src/client/types.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
import type { DevframeViewLauncher } from '@devframes/hub/types'
22
// Importing the hub-mounted json-render integration registers its
33
// `'json-render'` dock entry (a serializable `view` ref, not a live handle)
4-
// on the hub's open dock union via declaration merging.
4+
// on the hub's open dock union via declaration merging. This has to be a
5+
// value import, not `import type`, because TS rejects a type-only
6+
// side-effect import (no bindings to mark as type-only) — but it's still
7+
// fully erased at build time since nothing in dist ever references it, so
8+
// @devframes/json-render staying an *optional* peer below doesn't change
9+
// what ships.
510
import '@devframes/json-render/hub'
611

712
/**

0 commit comments

Comments
 (0)