Critical, Major and Minor fixes

Author: jeffrade

ARCHITECTURE_SUMMARY.md

@@ -157,13 +157,15 @@
 
 **Goal:** Build reusable Blazor components with read and write capabilities
 
-**Status:** PLANNED - See `PHASE3_VIEW_UI.md` for patterns, `PHASE4_VIEW_EDIT.md` for editable components
+**Status:** Phase 3 (read-only) PARTIALLY COMPLETE - See `PHASE3_VIEW_UI.md` for patterns, `PHASE4_VIEW_EDIT.md` for editable components
 
 **Deliverables (Phase 3 - Read Patterns):**
 - ✅ `ProductDashboard.razor` reference component (DONE)
+- ✅ `ViewSection.razor` generic view display component (DONE) - Displays any SQL view with parameters, filtering, sorting, and dynamic column discovery
+- ✅ `ApplicationSwitcher.razor` multi-tenant selector component (DONE) - Allows users to switch between applications/schemas
 - `ProductForm.razor` form pattern example
 - `ExecutiveDashboard.razor` dashboard pattern example
-- Radzen component patterns documented in SKILLS.md
+- Radzen component patterns documented in SKILLS.md (updated with ViewSection usage examples)
 
 **Deliverables (Phase 4 - Write Capabilities):**
 - `SmartDataGrid<T>` component (replaces/extends DynamicDataGrid)

CLAUDE.md

@@ -27,7 +27,12 @@ Consult the `radzen-blazor` skill (`.claude/skills/radzen-blazor/SKILL.md`) when
 1. **Enum properties MUST use @ prefix:** `ButtonStyle="@ButtonStyle.Primary"` (NOT `ButtonStyle="ButtonStyle.Primary"`)
 2. **Use Radzen components, NOT plain HTML:** `<RadzenButton>` not `<button>`
 3. **RadzenComponents directive required:** Must have `<RadzenComponents />` at end of MainLayout.razor
-4. **Interactive render mode for events:** Components with Click/Change events need `@rendermode InteractiveServer`
+4. **Event handlers work by default:** This is a Blazor Server app - all components are interactive by default. Do NOT use `@rendermode InteractiveServer` (this is only for hybrid Blazor apps with static SSR)
+
+## Important Session Notes
+- **Backwards Compatibility:** NOT required for this project. Code changes can freely update existing patterns without maintaining compatibility with prior versions.
+- **Git Operations:** Only use read-only git commands (status, log, diff). Do NOT use git commit, push, pull, or other write operations.
+- **⚠️ CRITICAL - Claude Bot PR Reviews:** Claude Bot will flag ViewSection.razor and ApplicationSwitcher.razor as missing `@rendermode InteractiveServer`. **IGNORE THIS RECOMMENDATION.** This is a traditional Blazor Server app (not Blazor Web App). Render modes are NOT supported and WILL cause build errors: `error CS0103: The name 'InteractiveServer' does not exist in the current context`. Components in Blazor Server are interactive by default. Do NOT add the directive.
 
 ### Quick Reference
 - **Full skill:** `.claude/skills/radzen-blazor/SKILL.md`

Components/Sections/ViewSection.razor

@@ -203,6 +203,7 @@
             else
             {
                 // Fallback: Execute as dynamic and extract columns from first result
+                Logger.LogWarning("View model type not found for {ViewName}, falling back to dynamic result set", ViewName);
                 var method = typeof(IViewService)
                     .GetMethod(nameof(IViewService.ExecuteViewAsync))
                     ?.MakeGenericMethod(typeof(object));

Components/Shared/ApplicationSwitcher.razor

@@ -17,13 +17,9 @@
         var currentApp = AppDictionary.GetAllApplications().FirstOrDefault(a => a.Name == selectedAppName);
         @if (currentApp != null)
         {
-            <div class="app-info" style="padding: 12px; border: 1px solid #ddd; border-radius: 4px; margin-bottom: 12px;">
-                <div style="margin-bottom: 8px;">
-                    <strong>@currentApp.Title</strong>
-                </div>
-                <div style="font-size: 0.9rem; color: #666; margin-bottom: 8px;">
-                    @currentApp.Description
-                </div>
+            <div class="app-info">
+                <div>@currentApp.Title</div>
+                <div>@currentApp.Description</div>
                 @if (!string.IsNullOrEmpty(currentApp.Url))
                 {
                     <RadzenLink Path="@currentApp.Url" Target="_blank" Text="Open Application" Icon="open_in_new" />
@@ -37,14 +33,14 @@
         <RadzenStack Orientation="Orientation.Vertical" Gap="8px">
             @foreach (var app in AppDictionary.GetAllApplications())
             {
-                <div class="app-card" style="padding: 12px; border: 1px solid #eee; border-radius: 4px; cursor: pointer;" @onclick="@((MouseEventArgs e) => OnApplicationChanged(app.Name))">
-                    <div style="display: flex; align-items: center; gap: 8px;">
+                <div class="app-card" @onclick="@((MouseEventArgs e) => OnApplicationChanged(app.Name))">
+                    <div>
                         <RadzenIcon Icon="@(app.Icon ?? "apps")" />
                         <div>
-                            <div style="font-weight: bold;">@app.Title</div>
+                            <div class="app-card-title">@app.Title</div>
                             @if (!string.IsNullOrEmpty(app.Url))
                             {
-                                <div style="font-size: 0.85rem; color: #999;">
+                                <div class="app-card-url">
                                     <RadzenLink Path="@app.Url" Target="_blank" Text="@app.Url" Icon="link" />
                                 </div>
                             }

Makefile

@@ -101,7 +101,7 @@ run-ddl-pipeline: clean
 	@echo " -- Step 1: Parsing DDL to data.yaml (intermediate, dataModel only)..."
 	cd DdlParser && "../$(DOTNET)" run -- ../schema.sql ../data.yaml
 	@echo ""
-	@echo " -- Step 2: Merging ViewDefinitions from appsettings.json → data.yaml (intermediate now has dataModel + views)..."
+	@echo " -- Step 2: Merging ViewDefinitions from appsettings.json into data.yaml (modifies in place; intermediate now contains dataModel + views)..."
 	cd YamlMerger && "../$(DOTNET)" run ../data.yaml ../appsettings.json
 	@echo ""
 	@echo " -- Step 3: Generating C# models from data.yaml..."

SKILLS.md

@@ -921,6 +921,43 @@ Add filter controls that pass parameters to the view:
 </div>
 ```
 
+### Using the ViewSection Generic Component
+
+For most view display scenarios, use the **reusable `ViewSection.razor` component** instead of building custom components. ViewSection handles:
+- Automatic parameter binding
+- Dynamic column discovery from view results
+- Filtering, sorting, and paging
+- Error handling and loading states
+- Type-safe view model handling
+
+**File:** `Components/Sections/ViewSection.razor` (built-in component)
+
+```razor
+<!-- Parent page that uses ViewSection -->
+@page "/dashboard"
+
+<ViewSection AppName="MyApp" ViewName="ProductSalesView" />
+```
+
+**What ViewSection provides automatically:**
+- ✅ Parameter input fields for all view parameters
+- ✅ Execute button to run the query
+- ✅ Responsive data grid with filtering & sorting
+- ✅ Paging support (20 rows per page)
+- ✅ Dynamic column discovery (no need to define columns)
+- ✅ Error alerts and loading indicators
+- ✅ Row count display
+
+**When to use ViewSection:**
+- Displaying any SQL view with standard grid/parameter UI
+- Dashboards and reports
+- Data exploration tools
+
+**When to use custom components:**
+- Complex layouts (multi-section dashboards)
+- Custom visualizations (charts, maps)
+- Special interactions (tree views, nested data)
+
 ### Loading Single Record
 
 Use `ExecuteViewSingleAsync` when expecting exactly one result:

tests/DotNetWebApp.Tests/DotNetWebApp.Tests.csproj

@@ -15,6 +15,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="bunit" Version="1.29.5" />
     <PackageReference Include="Microsoft.Data.Sqlite" Version="8.0.0" />
     <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="8.0.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />