Remove docker cli step in ci.yml#11549
Merged
Merged
Conversation
Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11549 +/- ##
==========================================
+ Coverage 58.26% 58.60% +0.33%
==========================================
Files 135 135
Lines 11550 11550
==========================================
+ Hits 6730 6769 +39
+ Misses 4155 4122 -33
+ Partials 665 659 -6 ☔ View full report in Codecov by Sentry. |
jhrotko
requested review from
crazy-max,
glours,
milas,
ndeloof and
ulyssessouza
jhrotko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Removed
Setup docker CLIstep because it was overriding docker version to25.0.1thus ignoring the matrix.engine versions previously installed.After looking at this PR, I noticed something was odd, since this network issue has been fixed not long ago.
(not mandatory) A picture of a cute animal, if possible in relation to what you did
