From b69e246cb43cc15ccb1329639cc69f0c3d71022e Mon Sep 17 00:00:00 2001
From: "Klare, Heiko" <Heiko.Klare@vector.com>
Date: Mon, 15 Jun 2026 20:26:48 +0200
Subject: [PATCH] Improve AGENTS.md: fix misleading and broken content

- Remove broken/malformed build command that concatenated two mvn
  invocations into one invalid command line
- Remove a "mvn clean test" example that doesn't work in Tycho projects
  (tests require "mvn verify")
- Rename "Critical Limitation" section to "Building Individual Bundles"
  for clarity
- Add missing instruction on how to include changed source bundles
  alongside test bundles in the -pl parameter
- Remove every information about -Pbuild-individual-bundle as it is
  already defined via .mvn/maven.config
- Restructure sections: merge scattered Testing/Common Development
  Commands content into coherent Build System and Development Hints
  sections; move "Finding test bundles" and JUnit guidelines next to
  related content
- Remove incorrect statement that Co-Authored-By trailers fail the
  Eclipse license check
---
 AGENTS.md | 56 ++++++++++++++++++++-----------------------------------
 1 file changed, 20 insertions(+), 36 deletions(-)

diff --git a/AGENTS.md b/AGENTS.md
index 1820101a8ee..bc4fecdb1c9 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -61,19 +61,15 @@ Each bundle contains:
 - `src/` or `eclipseui/` - Java source code
 - `.settings/` - Eclipse compiler settings
 
-## Build System
-
-### Critical Limitation
 
+## Build System
 
-Use the `-Pbuild-individual-bundles` profile:
+### Building Individual Bundles
 
 ```bash
-# Compile single bundle
-mvn clean compile -pl :bundle-artifact-id -Pbuild-individual-bundles -q
-
-# Example for building a single bundle
-mvn clean verify -Pbuild-individual-bundles mvn clean verify -pl bundles/org.eclipse.ui -DskipTests
+# Compile single bundle such as org.eclipse.jface
+mvn clean compile -pl :org.eclipse.jface
+```
 
 ### Test Properties
 
@@ -82,8 +78,6 @@ From `pom.xml`:
 - `tycho.surefire.useUIThread=true` - Run tests on UI thread
 - `failOnJavadocErrors=true` - Fail build on Javadoc errors
 
-## Testing
-
 ### Running Tests
 
 **⚠️ IMPORTANT:** Use `mvn verify` (NOT `mvn test`) for Tycho projects. 
@@ -91,31 +85,19 @@ Due to Maven Tycho lifecycle binding, tests run in the `integration-test` phase,
 
 ```bash
 # Run tests for a specific test bundle from repository root
-mvn clean verify -pl :org.eclipse.ui.tests -Pbuild-individual-bundles
-
-# Run specific test class within a bundle
-mvn clean verify -pl :org.eclipse.ui.tests -Pbuild-individual-bundles -Dtest=StructuredViewerTest
+mvn clean verify -pl :org.eclipse.jface.tests
 
-# Skip tests during compilation
-mvn clean compile -Pbuild-individual-bundles -DskipTests
+# Run a specific test class within a bundle
+mvn clean verify -pl :org.eclipse.jface.tests -Dtest=ViewerTest
 ```
 
-**Finding test bundles:** Test bundles mirror production bundles:
-- Production: `bundles/org.eclipse.jface`
-- Tests: `tests/org.eclipse.jface.tests`
-
-### JUnit Guidelines
-
-- Prefer JUnit 5 (`org.junit.jupiter.api.*`) for new tests
-
-## Common Development Commands
+If classes under test have been modified, include both the changed source bundle and the test bundle in `-pl`:
+```bash
+mvn clean verify -pl :org.eclipse.jface,:org.eclipse.jface.tests
+```
 
-### Compilation
 
-
-# Compile and run tests
-mvn clean test -pl :bundle-artifact-id -Pbuild-individual-bundles
-```
+## Development Hints
 
 ### Finding Code
 
@@ -130,9 +112,14 @@ cat bundles/org.eclipse.jface/META-INF/MANIFEST.MF
 grep -r "pattern" bundles/org.eclipse.jface/src
 ```
 
-## Git Commits
+**Finding test bundles:** Test bundles mirror production bundles:
+- Production: `bundles/org.eclipse.jface`
+- Tests: `tests/org.eclipse.jface.tests`
+
+### JUnit Guidelines
+
+- Prefer JUnit 5 (`org.junit.jupiter.api.*`) for new tests
 
-**Do NOT add `Co-Authored-By` or similar AI attribution trailers to commits.** This fails the Eclipse license check.
 
 ## Critical Development Rules
 
@@ -205,9 +192,6 @@ output.. = bin/
 
 ## Troubleshooting
 
-### "Non-resolvable parent POM"
-Expected when running `mvn verify` at root. Use `-Pbuild-individual-bundles` for individual bundles.
-
 ### "Package does not exist"
 Check `META-INF/MANIFEST.MF` - add missing package to `Import-Package` or bundle to `Require-Bundle`.