fix: Document changes of app.getGpuInfo('complete') #947
Conversation
Updated behavior for app.getGpuInfo to always fetch latest GPU info.
BOT-Man-JL
changed the title
There was a problem hiding this comment.
Thanks for opening the PR!
In my opinion, this is not a breaking change that we should list.
Whether or not the information is cached should be an implementation detail that shouldn't matter to the application that calls the function.
As it came up on the issue, it seems like the real bug that makes this problematic is the following:
The issue occurred when using app.getGpuInfo('complete') in periodic metrics reporting. After upgrading Electron from v28 to v37, some users experienced severe GPU process memory leaks and OOM crashes. The WPR traces pinpointed the cause to gpu::CollectDawnInfo and its internal Vulkan driver calls.
That's what we should actually fix.
EDIT: More information on the upstream bug here: electron/electron#49115
MarshallOfSound
left a comment
MarshallOfSound
left a comment
There was a problem hiding this comment.
Agree with @nikwen above, let's track the crash not report the internal behavior as a change
3 participants
Description of Change
Updated behavior for app.getGpuInfo to always fetch latest GPU info.
Close electron/electron#49108
Checklist