-
Notifications
You must be signed in to change notification settings - Fork 154
Fix: Handle Users with None Email in Admin Interface #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gaumrab
wants to merge
30
commits into
fossasia:enext
Choose a base branch
from
gaumrab:fix/user-none-email-display
base: enext
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
8c66a00
fix: update user email and fullname display defaults in admin templat…
gaumrab 8f3b4fd
fix: handle None email values in UserEditForm to improve user experience
gaumrab 9c1c9ec
Merge branch 'enext' into fix/user-none-email-display
mariobehling dc1956e
Merge branch 'enext' into fix/user-none-email-display
mariobehling f416461
fix(ui) unify navigation button styling across Tickets and Talk views…
ArnavBallinCode 38f84d7
fix(ui): prevent sidebar auto-collapse on navigation (#1306)
ArnavBallinCode a6636c2
Chore: remove ticket/video URL fields (#1309)
Saksham-Sirohi 30c28a8
remove logout button on video component (#1313)
Saksham-Sirohi b7856b5
PostgreSQL syntax error in Room permission query (#1314)
suhailnadaf509 7ca8ef7
fix unable to save config (#1295)
Saksham-Sirohi 6266c3f
Refactored the entire system to replace all legacy 'pretix/pretalx' r…
ArnavBallinCode f1ba6a7
bug: enable browser timezone for orders and mails optimizing filters …
Saksham-Sirohi 021c73b
chore(deps): update reportlab requirement from ==4.2.* to ==4.4.* (#1…
dependabot[bot] 7e65d34
chore: remove duplicate orga settings (#1320)
Saksham-Sirohi a81a1e0
chore(deps): update stripe requirement from ==13.2.* to ==14.0.* (#1327)
dependabot[bot] 018f1ac
chore(deps): update sentry-sdk requirement from ==2.44.* to ==2.45.* …
dependabot[bot] 3963cc7
Resolve Sidebar Icon Layout Shift (#1319)
ArnavBallinCode 4c92d7e
Fix: socialauth URLs were not resolved (#1324)
hongquan cd33fe8
Merge branch 'enext' into fix/user-none-email-display
mariobehling 8cda595
chore: add translations korean and indonesian (#1330)
Saksham-Sirohi 84dbee0
feature: added hidden rooms and ensure sync (#1184)
Saksham-Sirohi 978e73a
chore(deps): update geoip2 requirement from ==4.* to ==5.* (#1333)
dependabot[bot] 8d4d440
chore(deps): update redis requirement from ==7.0.* to ==7.1.* (#1329)
dependabot[bot] 3efab3b
Fix: HTTP 500 error handling during room deletion (#1280)
ArnavBallinCode 54f1945
Fix: gift card 500 error (#1260)
ArnavBallinCode ab3731d
Fix CSV Export Returns 500 Error (#1267)
prayag78 67d2ac5
Export orders with Wikimedia username (#1332)
hongquan 0011de0
bug: image rescaling fix (#1292)
Saksham-Sirohi 70a8496
fix(ui): match top menu bar between eventyay talk and eventyay ticket…
prayag78 2f3e282
Merge branch 'enext' into fix/user-none-email-display
mariobehling File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Stripping whitespace from email may cause issues for legitimate emails with leading/trailing spaces.
Consider validating and rejecting emails with leading or trailing spaces, rather than silently removing them, to avoid masking user input errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable. Please also show an error message for invalid emails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your feedback!
To show an error message for invalid emails, you can enhance the
clean_emailmethod in your form to use Django's built-in email validation. This way, if a user enters an email with leading/trailing spaces or an invalid format, the form will display a clear error message.Here's how you can update your
clean_emailmethod:This will:
Let me know if you need a full patch or further help integrating this!