-
Notifications
You must be signed in to change notification settings - Fork 154
refactor: replaced old pretix/venueless references with eventyay naming #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enext
Are you sure you want to change the base?
Conversation
Currently translated at 0.1% (3 of 4121 strings) Translation: eventyay/Eventyay Tickets Translate-URL: https://hosted.weblate.org/projects/open-event/eventyay-tickets/zh_Hant/
Currently translated at 0.2% (9 of 4121 strings) Translation: eventyay/Eventyay Tickets Translate-URL: https://hosted.weblate.org/projects/open-event/eventyay-tickets/zh_Hant/
Currently translated at 0.4% (18 of 4121 strings) Translation: eventyay/Eventyay Tickets Translate-URL: https://hosted.weblate.org/projects/open-event/eventyay-tickets/pl_INFORMAL/
Currently translated at 2.9% (123 of 4121 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/zh_Hant/
Currently translated at 2.9% (123 of 4121 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/zh_Hant/
The issue was caused by unconditional access to test_form.cleaned_data without checking if the form validation succeeded. When test_form.is_valid() returned False, accessing cleaned_data could raise AttributeError or return incomplete data, causing a 500 error. Solution: Added conditional check to only access cleaned_data when form is valid, otherwise use empty dict for initial values. This ensures the export page loads properly even when no valid GET parameters are provided. Changes: - Modified ExportMixin.exporters property in control/views/orders.py - Added validation check before accessing test_form.cleaned_data - Fallback to empty dict when form is invalid
Applied the same fix from issueto the organizer-level export
functionality. The ExportMixin in organizer.py had the identical issue
where test_form.cleaned_data was accessed without checking if the form
validation succeeded first.
This prevents potential HTTP 500 errors when accessing:
- /control/organizer/{organizer}/export/
Changes:
- Modified ExportMixin.exporters in control/views/organizer.py
- Added validation check before accessing test_form.cleaned_data
- Fallback to empty dict when form is invalid
- Use f-strings instead of string concatenation for better readability - Rename 'id' variable to 'identifier' to avoid shadowing builtin - Apply improvements to both orders.py and organizer.py Addresses Sourcery suggestions...
- Add JSON_FIELD_AVAILABLE setting based on database backend (postgresql = True) - Fix checkinlists exporter using old Event.items instead of Event.products - Resolves AttributeError when accessing export functionality
- Changed from if/else validation check to getattr() to preserve partial cleaned_data - This allows useful defaults even when form is partially invalid - Reverted unnecessary 'id' to 'identifier' rename in organizer.py - Renamed 'items' field to 'products' in checkinlists exporter for consistency - Updated form_data['items'] to form_data['products'] reference
…fossasia#1157) * Fix navigation button border radius inconsistency - Added border-radius: 0 to .header-nav class in orga/_layout.css - Makes Talk component navigation buttons match Tickets component style - Ensures consistent sharp corners across all navigation buttons - Maintains visual consistency throughout the platform Fixes fossasia#1156 * Add inset shadow on hover to match Tickets component - Added hover and active states with inset box-shadow - Matches the hover effect from btn-success in Tickets component - Uses rgba(0, 128, 0, 0.25) for green inset shadow * Fix navigation button active state to match Tickets component - Added .header-nav.active state with proper inset shadow - Fixed depth and consistency of hover, active, and current page states - Current page button now has same darker border effect as Tickets - All navigation buttons now have identical visual feedback * Improve CSS: use variables and remove important declarations * Fix CSS indentation formatting * Update app/eventyay/static/orga/css/_layout.css * Update app/eventyay/static/orga/css/_layout.css * Fix navigation buttons: sharp corners and inset shadow to match Tickets component --------- Co-authored-by: Mario Behling <[email protected]>
i18n(translations): update localized strings from Weblate
…speaker-acceptance-link-oof Fix Speaker Acceptance Confirmation Link Returning 500 Error
* fix(translations): Add missing languages * add(translation): Change language selection to drop down from check-box * fix(translation): Add changes suggested by ai comments * fix(translation): Updated Ukrainian to use the standard Django code `uk` --------- Co-authored-by: Mario Behling <[email protected]>
…4.* (fossasia#1401) Updates the requirements on [beautifulsoup4](https://www.crummy.com/software/BeautifulSoup/bs4/) to permit the latest version. --- updated-dependencies: - dependency-name: beautifulsoup4 dependency-version: 4.14.3 dependency-type: direct:production ... Signed-off-by: Mario Behling <[email protected]>
…sia#1400) Updates the requirements on [celery](https://github.com/celery/celery) to permit the latest version. - [Release notes](https://github.com/celery/celery/releases) - [Changelog](https://github.com/celery/celery/blob/main/Changelog.rst) - [Commits](celery/celery@v5.4.0rc1...v5.6.0) --- updated-dependencies: - dependency-name: celery dependency-version: 5.6.0 dependency-type: direct:production ... Signed-off-by: Mario Behling <[email protected]>
…rder (fossasia#1375) Co-authored-by: Mario Behling <[email protected]>
…ponent layout (fossasia#1377) * Move powered by eventyay below content area on Ticket Pages * update email condition * Apply Copilot suggestions * remove contact us --------- Co-authored-by: Mario Behling <[email protected]>
…ossasia#1378) Co-authored-by: Mario Behling <[email protected]>
…1412) * fix(language): Restore language selection to checkbox list * fix(selection): Add fixes to selection
* added template files * cfp * fix: Add options management interface for CFP custom fields * fix: Reorder form fields to match Pretalx * fix: Display Field required radio buttons inline with proper Bootstrap styling --------- Co-authored-by: Mario Behling <[email protected]>
) Currently translated at 95.5% (5278 of 5522 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/de/ Co-authored-by: Andreas Kleinert <[email protected]>
…a#1340) * Add auto-expanding textarea * guard to prevent duplication * inline JS to separate static file and other modifications * initial text area & resize * viewport-size * initial height & scrollbar appears only inside textarea not on page --------- Co-authored-by: Mario Behling <[email protected]>
* add logging * add defaults via migration
|
@Stackashu I found several issues with this PR
It should be 'eventyay_video'
This will cause template lookup failures, static file 404 errors, and URL resolution issues.
Without updating these, plugin detection will fail across the codebase. |
|
Ok @suhailnadaf509 , thankyou for reviewing this i will definitely fix this soon and raise this PR again |
Sak1012
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and update the PR
Description me likh dena:
Found and replaced all old references
Updated imports, template folders, PluginApp name etc.
Verified using automated search commands
Tested plugin loads without errors (if applicable)
Summary by Sourcery
Rename the event ticket video plugin to use the new eventyay_video naming across code and assets.
Enhancements: