From 4bfc8d020e99479525727eb9da6d613847eec385 Mon Sep 17 00:00:00 2001 From: gusty <1261319+gusty@users.noreply.github.com> Date: Sat, 20 Dec 2025 21:46:53 +0100 Subject: [PATCH 1/2] Add xml comments to Idiom bracket literals --- src/FSharpPlus/Builders.fs | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/FSharpPlus/Builders.fs b/src/FSharpPlus/Builders.fs index 585f34516..c6297bf34 100644 --- a/src/FSharpPlus/Builders.fs +++ b/src/FSharpPlus/Builders.fs @@ -28,7 +28,20 @@ module GenericBuilders = static member ($) (Idiomatic, Ii) = id let inline idiomatic a b = (Idiomatic $ b) a + /// + /// Marks the beginning of an idiom bracket (applicative style). + /// + /// + /// Use Ii to mark the end of the idiom bracket. let inline iI x = (idiomatic << result) x + + /// + /// Marks the end of an idiom bracket (applicative style). + /// + /// + /// Use iI to mark the beginning of the idiom bracket. + let Ii = Ii + type Idiomatic with static member inline ($) (Idiomatic, Ji) = fun xii -> join xii type Idiomatic with static member inline ($) (Idiomatic, J ) = fun fii x -> (Idiomatic $ x) (join fii) From e59636bb6b0b690de6cbc23392af16330bb69b97 Mon Sep 17 00:00:00 2001 From: Oskar Mathieu Gewalli Date: Mon, 22 Dec 2025 08:46:30 +0200 Subject: [PATCH 2/2] --- src/FSharpPlus/Builders.fs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/FSharpPlus/Builders.fs b/src/FSharpPlus/Builders.fs index c6297bf34..14d2033e6 100644 --- a/src/FSharpPlus/Builders.fs +++ b/src/FSharpPlus/Builders.fs @@ -33,6 +33,7 @@ module GenericBuilders = /// /// /// Use Ii to mark the end of the idiom bracket. + /// let inline iI x = (idiomatic << result) x /// @@ -40,8 +41,8 @@ module GenericBuilders = /// /// /// Use iI to mark the beginning of the idiom bracket. + /// let Ii = Ii - type Idiomatic with static member inline ($) (Idiomatic, Ji) = fun xii -> join xii type Idiomatic with static member inline ($) (Idiomatic, J ) = fun fii x -> (Idiomatic $ x) (join fii)