Skip to content

Commit 0b1f4a0

Browse files
authored
Merge pull request #566 from github/aeisenberg/update-release-branch-fix
Fix update-release-branch-fix.py
2 parents e284efb + efea923 commit 0b1f4a0

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/update-release-branch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def get_commit_difference(repo):
122122

123123
# Is the given commit the automatic merge commit from when merging a PR
124124
def is_pr_merge_commit(commit):
125-
return commit.committer.login == 'web-flow' and len(commit.parents) > 1
125+
return commit.committer is not None and commit.committer.login == 'web-flow' and len(commit.parents) > 1
126126

127127
# Gets a copy of the commit message that should display nicely
128128
def get_truncated_commit_message(commit):

.github/workflows/pr-checks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ jobs:
118118
with:
119119
config-file: ".github/codeql/codeql-config-packaging.yml"
120120
languages: javascript
121-
# TODO: this is temporary until we have a release that includes the latest packaging work.
122-
tools: https://github.com/dsp-testing/aeisenberg-codeql-action-packaging/releases/download/codeql-bundle-20210606/codeql-bundle-linux64.tar.gz
121+
# TODO: this can be removed when cli v2.5.6 is released and available in the tool cache
122+
tools: https://github.com/dsp-testing/aeisenberg-codeql-action-packaging/releases/download/codeql-bundle-20210615/codeql-bundle-linux64.tar.gz
123123

124124
- name: Build code
125125
shell: bash

tests/multi-language-repo/.github/codeql/codeql-config-packaging.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: Pack testing in the CodeQL Action
33
disable-default-queries: true
44
packs:
55
javascript:
6-
- dsp-testing/[email protected].3
6+
- dsp-testing/[email protected].4
77
- dsp-testing/codeql-pack2 # latest
88
paths-ignore:
99
- tests

0 commit comments

Comments
 (0)