Ruby: Implement localMustFlowStep #14303
Conversation
hvitved
force-pushed
the
ruby/must-flow
branch
from
66aa1c9 to
5ebedc7
Compare
hvitved
force-pushed
the
ruby/must-flow
branch
from
5ebedc7 to
faf717b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
ruby/must-flow
branch
from
faf717b to
9bc395b
Compare
hvitved
force-pushed
the
ruby/must-flow
branch
from
9bc395b to
8d913bd
Compare
hvitved
force-pushed
the
ruby/must-flow
branch
from
8d913bd to
83d3e65
Compare
hvitved
force-pushed
the
ruby/must-flow
branch
from
83d3e65 to
de0deab
Compare
| node2.asExpr() = SsaImpl::getARead(def) | ||
| ) | ||
| or | ||
| node1.asExpr() = node2.asExpr().(CfgNodes::ExprNodes::AssignExprCfgNode).getRhs() |
There was a problem hiding this comment.
This looks good to me, I was just wondering if there was overlap between this line and def.(Ssa::WriteDefinition).assigns(node1.asExpr()) above. Both seem to be related to assignments. Similar question about SsaFlow::toParameterNodeImpl and the special handling for (ImplicitBlockArgumentNode).getParameterNode(_).
There was a problem hiding this comment.
This looks good to me, I was just wondering if there was overlap between this line and def.(Ssa::WriteDefinition).assigns(node1.asExpr()) above. Both seem to be related to assignments.
The first line is about flow from e to SSA def for x in x = e, and the second line is about flow from e to the whole assignment expression x = e.
Similar question about SsaFlow::toParameterNodeImpl and the special handling for (ImplicitBlockArgumentNode).getParameterNode(_).
This is because implicit block parameters and arguments are not covered by our SSA analysis, otherwise you are right it would be an instance of that.
aibaars
left a comment
aibaars
left a comment
There was a problem hiding this comment.
LGTM, just had a question.
3 participants
Now that we track types in data flow, implementing
localMustFlowStepmeans that we will also get type-based call-target pruning, as implemented in the shared library.