Skip to content

Commit 1348de5

Browse files
committed
Surround tests with describe blocks
To better indicate which method they're testing.
1 parent 8521138 commit 1348de5

File tree

1 file changed

+41
-37
lines changed

1 file changed

+41
-37
lines changed

extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-manager.test.ts

Lines changed: 41 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -121,47 +121,51 @@ describe('Variant Analysis Manager', async function() {
121121
getVariantAnalysisRepoResultStub = sandbox.stub(ghApiClient, 'getVariantAnalysisRepoResult').resolves(arrayBuffer);
122122
});
123123

124-
it('should return early if variant analysis is cancelled', async () => {
125-
cancellationTokenSource.cancel();
126-
127-
await variantAnalysisManager.autoDownloadVariantAnalysisResult(
128-
scannedRepos[0],
129-
variantAnalysis,
130-
cancellationTokenSource.token
131-
);
132-
133-
expect(getVariantAnalysisRepoStub.notCalled).to.be.true;
134-
});
135-
136-
it('should fetch a repo task', async () => {
137-
await variantAnalysisManager.autoDownloadVariantAnalysisResult(
138-
scannedRepos[0],
139-
variantAnalysis,
140-
cancellationTokenSource.token
141-
);
142-
143-
expect(getVariantAnalysisRepoStub.calledOnce).to.be.true;
144-
});
145-
146-
it('should fetch a repo result', async () => {
147-
await variantAnalysisManager.autoDownloadVariantAnalysisResult(
148-
scannedRepos[0],
149-
variantAnalysis,
150-
cancellationTokenSource.token
151-
);
152-
153-
expect(getVariantAnalysisRepoResultStub.calledOnce).to.be.true;
124+
describe('autoDownloadVariantAnalysisResult', async () => {
125+
it('should return early if variant analysis is cancelled', async () => {
126+
cancellationTokenSource.cancel();
127+
128+
await variantAnalysisManager.autoDownloadVariantAnalysisResult(
129+
scannedRepos[0],
130+
variantAnalysis,
131+
cancellationTokenSource.token
132+
);
133+
134+
expect(getVariantAnalysisRepoStub.notCalled).to.be.true;
135+
});
136+
137+
it('should fetch a repo task', async () => {
138+
await variantAnalysisManager.autoDownloadVariantAnalysisResult(
139+
scannedRepos[0],
140+
variantAnalysis,
141+
cancellationTokenSource.token
142+
);
143+
144+
expect(getVariantAnalysisRepoStub.calledOnce).to.be.true;
145+
});
146+
147+
it('should fetch a repo result', async () => {
148+
await variantAnalysisManager.autoDownloadVariantAnalysisResult(
149+
scannedRepos[0],
150+
variantAnalysis,
151+
cancellationTokenSource.token
152+
);
153+
154+
expect(getVariantAnalysisRepoResultStub.calledOnce).to.be.true;
155+
});
154156
});
155157

156-
it('should pop download tasks off the queue', async () => {
157-
const getResultsSpy = sandbox.spy(variantAnalysisManager, 'autoDownloadVariantAnalysisResult');
158+
describe('enqueueDownload', async () => {
159+
it('should pop download tasks off the queue', async () => {
160+
const getResultsSpy = sandbox.spy(variantAnalysisManager, 'autoDownloadVariantAnalysisResult');
158161

159-
await variantAnalysisManager.enqueueDownload(scannedRepos[0], variantAnalysis, cancellationTokenSource.token);
160-
await variantAnalysisManager.enqueueDownload(scannedRepos[1], variantAnalysis, cancellationTokenSource.token);
161-
await variantAnalysisManager.enqueueDownload(scannedRepos[2], variantAnalysis, cancellationTokenSource.token);
162+
await variantAnalysisManager.enqueueDownload(scannedRepos[0], variantAnalysis, cancellationTokenSource.token);
163+
await variantAnalysisManager.enqueueDownload(scannedRepos[1], variantAnalysis, cancellationTokenSource.token);
164+
await variantAnalysisManager.enqueueDownload(scannedRepos[2], variantAnalysis, cancellationTokenSource.token);
162165

163-
expect(variantAnalysisManager.downloadsQueueSize()).to.equal(0);
164-
expect(getResultsSpy).to.have.been.calledThrice;
166+
expect(variantAnalysisManager.downloadsQueueSize()).to.equal(0);
167+
expect(getResultsSpy).to.have.been.calledThrice;
168+
});
165169
});
166170
});
167171
});

0 commit comments

Comments
 (0)