Skip to content

Commit 183de7b

Browse files
committed
Remove import cycle for query history domain mappers
1 parent b6f32ec commit 183de7b

File tree

4 files changed

+30
-29
lines changed

4 files changed

+30
-29
lines changed

extensions/ql-vscode/src/query-history/store/query-history-domain-mapper.ts

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@ import { assertNever } from "../../common/helpers-pure";
22
import type { QueryHistoryInfo } from "../query-history-info";
33
import { mapLocalQueryInfoToDto } from "./query-history-local-query-domain-mapper";
44
import type { QueryHistoryItemDto } from "./query-history-dto";
5-
import { QueryLanguageDto } from "./query-history-dto";
65
import { mapQueryHistoryVariantAnalysisToDto } from "./query-history-variant-analysis-domain-mapper";
7-
import { QueryLanguage } from "../../common/query-language";
86

97
export function mapQueryHistoryToDto(
108
queries: QueryHistoryInfo[],
@@ -19,28 +17,3 @@ export function mapQueryHistoryToDto(
1917
}
2018
});
2119
}
22-
23-
export function mapQueryLanguageToDto(
24-
language: QueryLanguage,
25-
): QueryLanguageDto {
26-
switch (language) {
27-
case QueryLanguage.CSharp:
28-
return QueryLanguageDto.CSharp;
29-
case QueryLanguage.Cpp:
30-
return QueryLanguageDto.Cpp;
31-
case QueryLanguage.Go:
32-
return QueryLanguageDto.Go;
33-
case QueryLanguage.Java:
34-
return QueryLanguageDto.Java;
35-
case QueryLanguage.Javascript:
36-
return QueryLanguageDto.Javascript;
37-
case QueryLanguage.Python:
38-
return QueryLanguageDto.Python;
39-
case QueryLanguage.Ruby:
40-
return QueryLanguageDto.Ruby;
41-
case QueryLanguage.Swift:
42-
return QueryLanguageDto.Swift;
43-
default:
44-
assertNever(language);
45-
}
46-
}
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
import { assertNever } from "../../common/helpers-pure";
2+
import { QueryLanguageDto } from "./query-history-dto";
3+
import { QueryLanguage } from "../../common/query-language";
4+
5+
export function mapQueryLanguageToDto(
6+
language: QueryLanguage,
7+
): QueryLanguageDto {
8+
switch (language) {
9+
case QueryLanguage.CSharp:
10+
return QueryLanguageDto.CSharp;
11+
case QueryLanguage.Cpp:
12+
return QueryLanguageDto.Cpp;
13+
case QueryLanguage.Go:
14+
return QueryLanguageDto.Go;
15+
case QueryLanguage.Java:
16+
return QueryLanguageDto.Java;
17+
case QueryLanguage.Javascript:
18+
return QueryLanguageDto.Javascript;
19+
case QueryLanguage.Python:
20+
return QueryLanguageDto.Python;
21+
case QueryLanguage.Ruby:
22+
return QueryLanguageDto.Ruby;
23+
case QueryLanguage.Swift:
24+
return QueryLanguageDto.Swift;
25+
default:
26+
assertNever(language);
27+
}
28+
}

extensions/ql-vscode/src/query-history/store/query-history-local-query-domain-mapper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import type {
1717
SortedResultSetInfo,
1818
} from "../../common/interface-types";
1919
import { SortDirection } from "../../common/interface-types";
20-
import { mapQueryLanguageToDto } from "./query-history-domain-mapper";
20+
import { mapQueryLanguageToDto } from "./query-history-language-domain-mapper";
2121

2222
export function mapLocalQueryInfoToDto(
2323
query: LocalQueryInfo,

extensions/ql-vscode/src/query-history/store/query-history-variant-analysis-domain-mapper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import {
2727
import { assertNever } from "../../common/helpers-pure";
2828
import { QueryStatus } from "../query-status";
2929
import type { VariantAnalysisHistoryItem } from "../variant-analysis-history-item";
30-
import { mapQueryLanguageToDto } from "./query-history-domain-mapper";
30+
import { mapQueryLanguageToDto } from "./query-history-language-domain-mapper";
3131

3232
export function mapQueryHistoryVariantAnalysisToDto(
3333
item: VariantAnalysisHistoryItem,

0 commit comments

Comments
 (0)