Enable func-style ESLint rule

Author: koesie10

extensions/ql-vscode/.eslintrc.js

@@ -53,7 +53,6 @@ const baseConfig = {
     "etc/no-implicit-any-catch": "error",
     "filenames/match-regex": "off",
     "filenames/match-regexp": "off",
-    "func-style": "off",
     "i18n-text/no-en": "off",
     "no-invalid-this": "off",
     "no-console": "off",

extensions/ql-vscode/src/common/helpers-pure.ts

@@ -27,13 +27,13 @@ export function assertNever(value: never): never {
 /**
  * Use to perform array filters where the predicate is asynchronous.
  */
-export const asyncFilter = async function <T>(
+export async function asyncFilter<T>(
   arr: T[],
   predicate: (arg0: T) => Promise<boolean>,
 ) {
   const results = await Promise.all(arr.map(predicate));
   return arr.filter((_, index) => results[index]);
-};
+}
 
 /**
  * This regex matches strings of the form `owner/repo` where:

extensions/ql-vscode/test/matchers/toEqualPath.ts

@@ -2,6 +2,7 @@ import { expect } from "@jest/globals";
 import type { MatcherFunction } from "expect";
 import { pathsEqual } from "../../src/common/files";
 
+// eslint-disable-next-line func-style -- We need to set the type of this function
 const toEqualPath: MatcherFunction<[expectedPath: unknown]> = function (
   actual,
   expectedPath,