Merge pull request #1847 from github/koesie10/typecheck-everything

Run type checking on all directories in CI

Author: koesie10

.github/workflows/main.yml

@@ -90,6 +90,11 @@ jobs:
           npm ci
         shell: bash
 
+      - name: Check types
+        working-directory: extensions/ql-vscode
+        run: |
+          npm run check-types
+
       - name: Lint
         working-directory: extensions/ql-vscode
         run: |

extensions/ql-vscode/gulpfile.ts/tsconfig.json

@@ -1,23 +1,8 @@
 {
   "$schema": "https://json.schemastore.org/tsconfig",
+  "extends": "../tsconfig.json",
   "compilerOptions": {
-    "declaration": true,
-    "strict": true,
-    "module": "commonjs",
-    "target": "es2021",
-    "lib": ["ES2021"],
-    "moduleResolution": "node",
-    "sourceMap": true,
-    "rootDir": ".",
-    "strictNullChecks": true,
-    "noFallthroughCasesInSwitch": true,
-    "preserveWatchOutput": true,
-    "newLine": "lf",
-    "noImplicitReturns": true,
-    "experimentalDecorators": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "esModuleInterop": true
+    "rootDir": "."
   },
   "include": ["*.ts"]
 }

extensions/ql-vscode/package.json

@@ -1299,6 +1299,7 @@
     "storybook": "start-storybook -p 6006",
     "build-storybook": "build-storybook",
     "lint:scenarios": "ts-node scripts/lint-scenarios.ts",
+    "check-types": "find . -type f -name \"tsconfig.json\" -not -path \"./node_modules/*\" | sed -r 's|/[^/]+$||' | sort | uniq | xargs -I {} sh -c \"echo Checking types in {} && cd {} && npx tsc --noEmit\"",
     "postinstall": "patch-package"
   },
   "dependencies": {

extensions/ql-vscode/src/stories/.eslintrc.js

@@ -1,10 +1,8 @@
 module.exports = {
   env: {
-    browser: true
+    browser: true,
   },
-  plugins: [
-    "github",
-  ],
+  plugins: ["github"],
   extends: [
     "plugin:github/react",
     "plugin:github/recommended",
@@ -16,12 +14,13 @@ module.exports = {
   rules: {
     "filenames/match-regex": "off",
     "import/named": "off",
+    "import/no-namespace": "off",
     "import/no-unresolved": "off",
     "no-unused-vars": "off",
   },
   settings: {
     react: {
-      version: 'detect'
-    }
-  }
-}
+      version: "detect",
+    },
+  },
+};

extensions/ql-vscode/src/stories/common/Alert.stories.tsx

@@ -1,4 +1,4 @@
-import React from "react";
+import * as React from "react";
 
 import { ComponentStory, ComponentMeta } from "@storybook/react";
 import { VSCodeButton, VSCodeLink } from "@vscode/webview-ui-toolkit/react";

extensions/ql-vscode/src/stories/common/CodePaths.stories.tsx

@@ -1,4 +1,4 @@
-import React from "react";
+import * as React from "react";
 
 import { ComponentStory, ComponentMeta } from "@storybook/react";
 import { ThemeProvider } from "@primer/react";

extensions/ql-vscode/src/stories/common/FileCodeSnippet.stories.tsx

@@ -1,4 +1,4 @@
-import React from "react";
+import * as React from "react";
 
 import { ComponentStory, ComponentMeta } from "@storybook/react";
 

extensions/ql-vscode/src/stories/common/LastUpdated.stories.tsx

@@ -1,4 +1,4 @@
-import React from "react";
+import * as React from "react";
 
 import { ComponentStory, ComponentMeta } from "@storybook/react";
 

extensions/ql-vscode/src/stories/common/StarCount.stories.tsx

@@ -1,4 +1,4 @@
-import React from "react";
+import * as React from "react";
 
 import { ComponentStory, ComponentMeta } from "@storybook/react";
 

extensions/ql-vscode/src/stories/common/icon/Codicon.stories.tsx

@@ -1,12 +1,12 @@
-import React from "react";
+import * as React from "react";
 
 import { ComponentStory, ComponentMeta } from "@storybook/react";
 
 import { CodePaths, Codicon as CodiconComponent } from "../../../view/common";
 
 // To regenerate the icons, use the following command from the `extensions/ql-vscode` directory:
 // jq -R '[inputs | [splits(", *")] as $row | $row[0]]' < node_modules/@vscode/codicons/dist/codicon.csv > src/stories/common/icon/vscode-icons.json
-import icons from "./vscode-icons.json";
+import * as icons from "./vscode-icons.json";
 
 export default {
   title: "Icon/Codicon",