Skip to content

Commit f04c346

Browse files
authored
Set in memory variant analysis on submission (#1673)
1 parent a217b53 commit f04c346

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,7 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA
6262
// it was purged by another workspace.
6363
this._onVariantAnalysisRemoved.fire(variantAnalysis);
6464
} else {
65-
this.variantAnalyses.set(variantAnalysis.id, variantAnalysis);
66-
await this.getView(variantAnalysis.id)?.updateView(variantAnalysis);
65+
await this.setVariantAnalysis(variantAnalysis);
6766
if (status === QueryStatus.InProgress) {
6867
// In this case, last time we checked, the query was still in progress.
6968
// We need to setup the monitor to check for completion.
@@ -140,18 +139,23 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA
140139
return;
141140
}
142141

143-
this.variantAnalyses.set(variantAnalysis.id, variantAnalysis);
144-
145-
await this.getView(variantAnalysis.id)?.updateView(variantAnalysis);
142+
await this.setVariantAnalysis(variantAnalysis);
146143
this._onVariantAnalysisStatusUpdated.fire(variantAnalysis);
147144
}
148145

149146
public async onVariantAnalysisSubmitted(variantAnalysis: VariantAnalysis): Promise<void> {
147+
await this.setVariantAnalysis(variantAnalysis);
148+
150149
await this.prepareStorageDirectory(variantAnalysis.id);
151150

152151
this._onVariantAnalysisAdded.fire(variantAnalysis);
153152
}
154153

154+
private async setVariantAnalysis(variantAnalysis: VariantAnalysis): Promise<void> {
155+
this.variantAnalyses.set(variantAnalysis.id, variantAnalysis);
156+
await this.getView(variantAnalysis.id)?.updateView(variantAnalysis);
157+
}
158+
155159
private async onRepoResultLoaded(repositoryResult: VariantAnalysisScannedRepositoryResult): Promise<void> {
156160
await this.getView(repositoryResult.variantAnalysisId)?.sendRepositoryResults([repositoryResult]);
157161
}

0 commit comments

Comments
 (0)