fix(gate): use '.' separator in build tags so ADO doesn't reject ':' in REST path#917
Merged
Merged
Conversation
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix gate.js to avoid colons in emitted build tags
fix(gate): use '.' separator in build tags so ADO doesn't reject ':' in REST path
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADO puts build tags in the REST request path (
PUT …/builds/<id>/tags/<tag>), and ASP.NET's request-path validator rejects:with "A potentially dangerous Request.Path value was detected". The gate emitted tags likepr-gate:passed, so every PR-gated pipeline failed on theaddBuildTagstep.Switch the tag separator from
:to.at all gate call sites:bypass.ts→${tag_prefix}.passedselfcancel.ts→${tag_prefix}.skippedpredicates.ts(failed-check path) →${tag_prefix}.${tag_suffix}bypass.test.ts/selfcancel.test.tsassert the emitted##vso[build.addbuildtag]line contains no:; existing gate-tag expectations updated to the dot form.test_tag_prefix_has_no_colon) confirmstag_prefixitself is colon-free for bothPullRequestandPipelineCompletion.Blast radius: consumers filtering on the old colon-form tags (
pr-gate:passed, etc.) must update to the dot form. The format is internal to the gate, so impact is expected to be near-zero.Test plan
npm test(ado-script): 251 tests pass;tsc --noEmitcleancargo test --bin ado-aw test_tag_prefix_has_no_colonpasses