fix URLs in summary for scheduled workflows #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@zricethezav Any updates on this? 🙏 |
acidghost
force-pushed
the
issue-121-fix-summary-urls
branch
from
c96278d to
9a671e2
Compare
|
Have the same problem, would be great to push this fix. |
|
Same problem here, can we have this merged! |
adamlahbib
approved these changes
Mar 28, 2025
Author
|
@zricethezav gentle ping |
|
Hi! I also need this change applied... merge please?! |
acidghost
force-pushed
the
issue-121-fix-summary-urls
branch
from
6374f6e to
1d6da16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121.
I tested privately that on scheduled workflows (i.e. with
scheduleevent type), therepositoryproperty is set the same as for other event types.I therefore removed the
ifblock that overwritesrepositoryand omitshtml_url.