fix: resolve loop-local refs in task expansion#2861
Closed
Yongcheng123 wants to merge 1 commit into
Closed
Conversation
Contributor
|
@Yongcheng123 why have you opened this PR for an issue that already has an open PR? |
Author
|
Good catch — I missed the existing open PR for #2505. I am closing this one to avoid duplicating work. Thanks for pointing it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ref:values against loop-local variables during task expansion.ITEMand aliased loop vars incmdsanddepsref:behavior by keeping the extra context scoped to loop expansionTesting
go test ./... -run 'TestForCmds|TestForDeps'go test ./...go vet ./...Closes #2505