Update default database path #1069
Open
+25
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolaente
reviewed
Jul 2, 2025
pkg/config/config.go
Outdated
|
|
||
| // Update the database path to match a changed rootpath when it was not explicitly set | ||
| defaultDBPath := filepath.Join(getBinaryDirLocation(), "vikunja.db") | ||
| if DatabasePath.GetString() == defaultDBPath { |
Member
There was a problem hiding this comment.
This seems redundant since the default root path is the directory of the binary?
Contributor
Author
There was a problem hiding this comment.
If I understood it correctly, that's incorrect.
Because database.path is calculated before service.rootpath (from the user) is read.
=> gets “stuck” on the binary-directory path.
I replaced to code to make it clearer.
Member
There was a problem hiding this comment.
But shouldn't the fix then be to initialize the rootpath before the database path?
dpschen
force-pushed
the
feat/update-default-databasepath-and-documentation
branch
from
34b11e9 to
b28ad0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.