-
-
Notifications
You must be signed in to change notification settings - Fork 254
ci(pr-docker): add disk cleanup and support fork registries #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(pr-docker): add disk cleanup and support fork registries #1942
Conversation
|
I wanted to make use of the PR Docker Build workflow to test another feature I was looking to add to Vikunja, but ran into two problems:
|
|
(Happy to split this up into two separate PR's if that's preferred!) |
|
Well, since the build is still failing, I wonder if that's really a solution here. |
|
Checking this again, the Docker build preview workflow only runs using the base pull request target, it does not take into account the changes that have been made to the workflow itself in a PR. That's why the changes from this PR don't run there. I've incorporated the cleanup step in 7a05f20 - let's see if that works. Pushing the changes to a fork does not need to work because it will always push the changes to the Vikunja main repo. It doesn't need to use the forked ghcr, it should just work. What issues did you encounter with that? |
Yes, that's correct -- I ran into this when testing it myself! |
I received 403 errors when running this workflow from a base pull request target in my forked repo because my repo doesn't have permission to push to Vikunja's main repo.
While developing my feature, I wanted to be able to test it in a Docker image before submitting a PR upstream, making use of the existing workflow for publishing to GitHub Container Registry. I wanted the option of publishing to my fork's Container Registry instead of upstream's before I had proved that my feature worked as intended. This functionality would also be useful for anyone wishing to maintain a customized fork of Vikunja |
|
Ahh, now I understand your point. Thanks for clarifying. I'd say let's add this. Since the cleanup changes are already integrated, can you rebase this PR so that it only contains the changes for the fork registries? |
Use dynamic repository owner/name for image tags to allow forks to publish to their own registries.
ad0e735 to
9ba2fd0
Compare
|
@kolaente Done! |
kolaente
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add disk space cleanup step to prevent runner disk exhaustion during Docker builds. Use dynamic repository owner/name for image tags to allow forks to publish to their own registries.