Skip to content

Commit 8af5e03

Browse files
google-genai-botcopybara-github
authored andcommitted
feat: Return List instead of ImmutableList in CallbackUtil methods
PiperOrigin-RevId: 886725038
1 parent bf5ca82 commit 8af5e03

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

core/src/main/java/com/google/adk/agents/BaseAgent.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,8 @@ public B beforeAgentCallback(BeforeAgentCallback beforeAgentCallback) {
529529

530530
@CanIgnoreReturnValue
531531
public B beforeAgentCallback(List<Callbacks.BeforeAgentCallbackBase> beforeAgentCallback) {
532-
this.beforeAgentCallback = CallbackUtil.getBeforeAgentCallbacks(beforeAgentCallback);
532+
this.beforeAgentCallback =
533+
ImmutableList.copyOf(CallbackUtil.getBeforeAgentCallbacks(beforeAgentCallback));
533534
return self();
534535
}
535536

@@ -541,7 +542,8 @@ public B afterAgentCallback(AfterAgentCallback afterAgentCallback) {
541542

542543
@CanIgnoreReturnValue
543544
public B afterAgentCallback(List<Callbacks.AfterAgentCallbackBase> afterAgentCallback) {
544-
this.afterAgentCallback = CallbackUtil.getAfterAgentCallbacks(afterAgentCallback);
545+
this.afterAgentCallback =
546+
ImmutableList.copyOf(CallbackUtil.getAfterAgentCallbacks(afterAgentCallback));
545547
return self();
546548
}
547549

core/src/main/java/com/google/adk/agents/CallbackUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public final class CallbackUtil {
4242
* @return normalized async callbacks, or empty list if input is null.
4343
*/
4444
@CanIgnoreReturnValue
45-
public static ImmutableList<BeforeAgentCallback> getBeforeAgentCallbacks(
45+
public static List<BeforeAgentCallback> getBeforeAgentCallbacks(
4646
List<BeforeAgentCallbackBase> beforeAgentCallbacks) {
4747
return getCallbacks(
4848
beforeAgentCallbacks,
@@ -59,7 +59,7 @@ public static ImmutableList<BeforeAgentCallback> getBeforeAgentCallbacks(
5959
* @return normalized async callbacks, or empty list if input is null.
6060
*/
6161
@CanIgnoreReturnValue
62-
public static ImmutableList<AfterAgentCallback> getAfterAgentCallbacks(
62+
public static List<AfterAgentCallback> getAfterAgentCallbacks(
6363
List<AfterAgentCallbackBase> afterAgentCallback) {
6464
return getCallbacks(
6565
afterAgentCallback,

0 commit comments

Comments
 (0)